Skip to content

Conversation

@crasbe
Copy link
Contributor

@crasbe crasbe commented Oct 15, 2025

Contribution description

As discovered in #21776, ztimer does not check if the .max field in the timer_config structure matches the TIMER_0_MAX_VALUE (if defined at all) definition. If it is not set, it assumes 32-bit width, which can lead to odd effects.

I extended the guide a bit to point to this issue.

Testing procedure

Check that the documentation still looks good

Issues/PRs references

Discoverd in #21776.

@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Oct 15, 2025
@github-actions github-actions bot added the Area: doc Area: Documentation label Oct 15, 2025
@riot-ci
Copy link

riot-ci commented Oct 15, 2025

Murdock results

✔️ PASSED

7cacc4f doc/guides: Add timer information to Porting Boards

Success Failures Total Runtime
1 0 1 01m:12s

Artifacts

Copy link
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me, ty crasbe :)

@crasbe crasbe force-pushed the pr/guide_porting_boards branch from 2b27155 to 7cacc4f Compare October 15, 2025 13:04
@crasbe crasbe added this pull request to the merge queue Oct 15, 2025
Merged via the queue into RIOT-OS:master with commit e4a031c Oct 15, 2025
26 checks passed
@crasbe crasbe deleted the pr/guide_porting_boards branch October 15, 2025 14:01
@crasbe
Copy link
Contributor Author

crasbe commented Oct 15, 2025

Thanks for the reviews :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants