Skip to content

Optimize compare literals #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Optimize compare literals #4389

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01cdcd2
check if instruction is actually a literal
aarushijai Oct 15, 2025
002e081
move check before calling getliteral
aarushijai Oct 15, 2025
01f74ef
removing get_literal
aarushijai Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/simplify_qdq.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,16 +365,14 @@ bool compare_literals(instruction_ref ins1, instruction_ref ins2)
auto x = ins1->eval();
if(x.empty())
return false;
auto literal1 = ins1->get_literal();
if(ins2->name() == "broadcast" or ins2->name() == "multibroadcast")
ins2 = ins2->inputs().front();
auto y = ins2->eval();
if(y.empty())
return false;
auto literal2 = ins2->get_literal();

bool diff_shapes_equal_vals = false;
visit_all(ins1->get_literal(), ins2->get_literal())([&](const auto l1, const auto l2) {
visit_all(x, y)([&](const auto l1, const auto l2) {
diff_shapes_equal_vals =
std::all_of(l1.begin() + 1,
l1.end(),
Expand Down
Loading