[CK_TILE] Enable vector stores for C Column Layout #3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aosewski
reviewed
Oct 21, 2025
Comment on lines
+265
to
+279
| static constexpr index_t NumYXdlPerWavePerShuffle = | ||
| IsERowMajor ? NumMXdlPerWavePerShuffle : NumNXdlPerWavePerShuffle; | ||
| static constexpr index_t NumXXdlPerWavePerShuffle = | ||
| IsERowMajor ? NumNXdlPerWavePerShuffle : NumMXdlPerWavePerShuffle; | ||
|
|
||
| static constexpr index_t YPerIterationShuffle = | ||
| IsERowMajor ? MPerIterationShuffle : NPerIterationShuffle; | ||
| static constexpr index_t XPerIterationShuffle = | ||
| IsERowMajor ? NPerIterationShuffle : MPerIterationShuffle; | ||
|
|
||
| static constexpr index_t YPerBlock = IsERowMajor ? kMPerBlock : kNPerBlock; | ||
| static constexpr index_t XPerBlock = IsERowMajor ? kNPerBlock : kMPerBlock; | ||
|
|
||
| static constexpr index_t YWave = IsERowMajor ? MWave : NWave; | ||
| static constexpr index_t XWave = IsERowMajor ? NWave : MWave; |
There was a problem hiding this comment.
Why not using those? Thanks to this you get cleaner code without all those boilerplate if constexpr is_same.... RowMajor stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered