Skip to content

[CK_BUILDER] Rename CK Builder test targets with consistent prefix test_ckb #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 30, 2025
Merged

[CK_BUILDER] Rename CK Builder test targets with consistent prefix test_ckb #3114

merged 8 commits into from
Oct 30, 2025
+60 −18

Conversation

@vpietila-amd
Copy link
Contributor

Proposed changes

  • Renamed the CMake build targets for CK Builder tests with prefix test_ckb. This follows the convention used by CK Tile that uses prefix test_ck_tile.
  • Created a new CMake target test_ckb_all that builds all CK Builder tests that have prefix test_ckb in the target name.
  • Update CK Builder Readme.

Snektron
Snektron previously approved these changes Oct 29, 2025
View reviewed changes
amd-anclark
amd-anclark previously approved these changes Oct 29, 2025
View reviewed changes
shumway
shumway previously approved these changes Oct 29, 2025
View reviewed changes
@vpietila-amd vpietila-amd dismissed stale reviews from shumway, amd-anclark, and Snektron via a55510a October 29, 2025 15:38
@shumway shumway merged commit 90da26c into develop Oct 30, 2025
49 checks passed
@shumway shumway deleted the vpietila/ckb-consistent-naming-of-cmake-test-targets branch October 30, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumway shumway shumway approved these changes

@Snektron Snektron Snektron left review comments

@amd-anclark amd-anclark amd-anclark left review comments

@illsilin illsilin Awaiting requested review from illsilin illsilin is a code owner

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@qianfengz qianfengz Awaiting requested review from qianfengz qianfengz is a code owner

@aosewski aosewski Awaiting requested review from aosewski aosewski is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@geyyer geyyer Awaiting requested review from geyyer geyyer is a code owner

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

@andriy-ca andriy-ca Awaiting requested review from andriy-ca andriy-ca is a code owner

@afagaj afagaj Awaiting requested review from afagaj afagaj is a code owner

@asleepzzz asleepzzz Awaiting requested review from asleepzzz asleepzzz is a code owner

@ThomasNing ThomasNing Awaiting requested review from ThomasNing ThomasNing is a code owner

@coderfeli coderfeli Awaiting requested review from coderfeli coderfeli is a code owner

@cgmillette cgmillette Awaiting requested review from cgmillette cgmillette is a code owner

@vidyasagar-amd vidyasagar-amd Awaiting requested review from vidyasagar-amd vidyasagar-amd is a code owner

@ddembeckAMD ddembeckAMD Awaiting requested review from ddembeckAMD ddembeckAMD is a code owner

@tenpercent tenpercent Awaiting requested review from tenpercent tenpercent is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vpietila-amd @shumway @Snektron @amd-anclark