Skip to content

Conversation

@amd-anclark
Copy link
Collaborator

@amd-anclark amd-anclark commented Oct 30, 2025

Proposed changes

  • Two new failure patterns have been added to the list: GPU not found and Redis connection time out patterns.
  • The logic for sending notifications was recently moved which introduced a bug. I moved failurePatterns variable to live in the failure notifications function scope so that it can access the list of failure patterns.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

How was this tested

The new failure was tested by forcing a stage failure and echoing the error message. The pattern was discovered and the message was sent to the Teams channel.

Also, failurePatterns does not need to be global. Moved variable to live in the failure notifications function scope.
@AviralGoelAMD
Copy link
Collaborator

LGTM!

@amd-anclark amd-anclark changed the title Adding GPU not found pattern Adding new alert failure patterns Oct 30, 2025
@illsilin illsilin merged commit 1977e4b into develop Oct 31, 2025
44 checks passed
@illsilin illsilin deleted the jenkins-no-gpu-alert branch October 31, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants