Skip to content

SWDEV-558502 - Test hipcc -> amdclang__ symlink for compiler PSDBs #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: amd-staging
Choose a base branch
from
+4 −2
Open

SWDEV-558502 - Test hipcc -> amdclang__ symlink for compiler PSDBs #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions amd/hipcc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ install(TARGETS ${HIPCONFIG_BIN}
COMPONENT NVIDIA
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})

add_custom_target(link_target ALL COMMAND ${CMAKE_COMMAND} -E create_symlink \"amdclang++\" ${HIPCC_BIN})

# TODO: WIN32 check need to be removed if backward
# compatibility is required for WIN32.
option(HIPCC_BACKWARD_COMPATIBILITY "Enable HIPCC backward compatibility" ON)
Expand Down
4 changes: 2 additions & 2 deletions clang/tools/amdllvm/amdllvm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ int main(int argc, char *argv[]) {

llvm::ExitOnError Exit((Alias + ": ").str());

if (!Alias.consume_front("amd")) {
/* if (!Alias.consume_front("amd")) {
Exit(createStringError("binary '" + Alias + "' not prefixed by 'amd'."));
}

*/
void *MainAddr = reinterpret_cast<void *>(main);
std::string AMDLlvmPath = fs::getMainExecutable(argv[0], MainAddr);
if (AMDLlvmPath.empty()) {
Expand Down