Update CMakeLists.txt #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag to disable the Canary is named wrong when adding to NO_MITS_FLAGS in CMakeLists.txt. It is defined as DISABLE_CANARY_FLAG but added as DISABLE_CANARIES_FLAG. This leads to all binaries build with NO_MITS_FLAGS still having a Canary. This pull requests fixes the issue by changing the flag name consistendly to DISABLE_CANARY_FLAG, in the definition as well as when it is added to NO_MITS_FLAGS.
dstadulis
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag to disable the Canary is named wrong when adding to NO_MITS_FLAGS in CMakeLists.txt.
It is defined as DISABLE_CANARY_FLAG but added as DISABLE_CANARIES_FLAG.
This leads to all binaries build with NO_MITS_FLAGS still having a Canary.
This pull requests fixes the issue by changing the flag name consistendly to DISABLE_CANARY_FLAG,
in the definition as well as when it is added to NO_MITS_FLAGS.