bsp:Phytium开发板适配 #10533
bsp:Phytium开发板适配 #10533
Conversation
|
|
github-actions
bot
added
BSP
component: net
BSP: Phytium
适配Phytium开发板
|
可以合入吗？这个错误避免不了 |
There was a problem hiding this comment.
Pull Request Overview
This PR adapts RT-Thread for Phytium development boards by updating the BSP (Board Support Package) configuration. The changes primarily focus on configuration file updates for the E2000D demo board and general Phytium board support improvements.
Key changes include:
- Removal of specific board configuration files for E2000D demo RT-Smart mode
- Updates to main application logic for different board types
- Documentation improvements for board selection process
- Configuration updates for aarch32 and aarch64 architectures
Reviewed Changes
Copilot reviewed 30 out of 117 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bsp/phytium/aarch64/configs/e2000d_demo_rtsmart.h | Removed complete configuration header file |
| bsp/phytium/aarch64/configs/e2000d_demo_rtsmart | Removed complete configuration file |
| bsp/phytium/aarch64/applications/main.c | Updated board type checks and added auto-test functionality |
| bsp/phytium/aarch64/README.md | Updated documentation for board selection process |
| bsp/phytium/aarch64/.config | Updated board configuration settings |
| bsp/phytium/aarch64/.ci/attachconfig/ci.attachconfig.yml | Added CI configuration for multiple board types |
| bsp/phytium/aarch32/thread-env.sh | Fixed architecture display message |
| bsp/phytium/aarch32/rtconfig.h.origin | Updated board configuration |
| bsp/phytium/aarch32/rtconfig.h | Updated board configuration |
| bsp/phytium/aarch32/makefile | Simplified build configuration and file naming |
| bsp/phytium/aarch32/configs/phytium_pi_rtthread_pusb2_hc.h | Removed configuration file |
Comments suppressed due to low confidence (1)
bsp/phytium/aarch64/applications/main.c:29
- The TARGET defines have been changed from TARGET_E2000D to TARGET_PE2202, but the comment on line 34 still refers to '4 cores at most' when TARGET_PD2408 should support 8 cores based on the configuration. This inconsistency should be corrected.
#if defined(TARGET_PE2202)
| @@ -5,7 +5,7 @@ export RTT_EXEC_PATH=$(pwd)/tools/gcc-arm-10.3-2021.07-x86_64-arm-none-eabi/bin | |||
| export RTT_CC_PREFIX=arm-none-eabi- | |||
| export PATH=$PATH:$RTT_EXEC_PATH | |||
|
|
|||
| echo "arch => aarch64" | |||
| echo "arch => aarch32" | |||
There was a problem hiding this comment.
The echo statement was corrected from 'aarch64' to 'aarch32', which is the correct fix for this aarch32 environment script.
Copilot uses AI. Check for mistakes.
| @@ -614,7 +614,7 @@ tcpip_init(tcpip_init_done_fn initfunc, void *arg) | |||
| } | |||
| #endif /* LWIP_TCPIP_CORE_LOCKING */ | |||
|
|
|||
| sys_thread_new(TCPIP_THREAD_NAME, tcpip_thread, NULL, TCPIP_THREAD_STACKSIZE, TCPIP_THREAD_PRIO); | |||
There was a problem hiding this comment.
按照之前的优先级设置，会掉包
There was a problem hiding this comment.
查了一下，TCPIP_THREAD_PRIO 的定义是：RT_LWIP_TCPTHREAD_PRIORITY。
那直接修改 RT_LWIP_TCPTHREAD_PRIORITY 就行？，不建议去修改LWIP内部的代码
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up