-
Notifications
You must be signed in to change notification settings - Fork 161
Add gaussian and poisson noise options to projection applications #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b2d59a8 to
ef55545
Compare
aee5dac to
1cbeb80
Compare
lesaintjerome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a few tests. It seems to run fine.
The noise feature in rtkdrawgeometricphantom and rtkprojectshepplogan has not been removed. Should it be?
| section "Gaussian noise" | ||
| option "gaussian" - "Gaussian noise parameters: <mean> Noise level and <std> Noise standard deviation" double multiple no | ||
|
|
||
| section "Poisson noise" | ||
| option "poisson" - "Poisson noise parameters: <I0> Number of impinging photons per pixel and <muref> reference linear attenuation coefficient" double multiple no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to make the mu_ref parameter mandatory. Why not. Though we could mention something like "e.g. set 0.01879, which is the attenuation coefficient of water at 75 keV".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same could be said about the mean parameter for gaussian noise. Default=0. would make sense, to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that we can't use different default values for lists with gengetopt, so the same default value will be used for mean and std for example.
We can maybe add theses default values to the implementation part ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or have slightly more complex Gaussian and Poisson ggo sections, with 2 parameters each?
No description provided.