Skip to content

Conversation

@axel-grc
Copy link
Collaborator

No description provided.

@axel-grc axel-grc force-pushed the Noise branch 2 times, most recently from b2d59a8 to ef55545 Compare November 24, 2025 08:56
@SimonRit SimonRit mentioned this pull request Nov 27, 2025
@axel-grc axel-grc force-pushed the Noise branch 3 times, most recently from aee5dac to 1cbeb80 Compare November 28, 2025 10:12
Copy link
Collaborator

@lesaintjerome lesaintjerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a few tests. It seems to run fine.
The noise feature in rtkdrawgeometricphantom and rtkprojectshepplogan has not been removed. Should it be?

Comment on lines +1 to +5
section "Gaussian noise"
option "gaussian" - "Gaussian noise parameters: <mean> Noise level and <std> Noise standard deviation" double multiple no

section "Poisson noise"
option "poisson" - "Poisson noise parameters: <I0> Number of impinging photons per pixel and <muref> reference linear attenuation coefficient" double multiple no
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to make the mu_ref parameter mandatory. Why not. Though we could mention something like "e.g. set 0.01879, which is the attenuation coefficient of water at 75 keV".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same could be said about the mean parameter for gaussian noise. Default=0. would make sense, to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that we can't use different default values for lists with gengetopt, so the same default value will be used for mean and std for example.

We can maybe add theses default values to the implementation part ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or have slightly more complex Gaussian and Poisson ggo sections, with 2 parameters each?

@SimonRit SimonRit self-assigned this Dec 18, 2025
@axel-grc axel-grc changed the title WIP: Add gaussian and poisson noise options to projection applications Add gaussian and poisson noise options to projection applications Dec 19, 2025
@SimonRit SimonRit added this to the RTK 3.0 milestone Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants