Skip to content

Conversation

badasahog
Copy link
Contributor

closes #7069

There's a lot I can do from here to remove static/global objects and speed up the code.

More to come.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (3bb2e76) to head (90a4db4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7206   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          81       81           
  Lines       15477    15477           
=======================================
  Hits        15325    15325           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Jul 23, 2025

  • HEAD=pythonRemoval slower P<0.001 for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit 90a4db4

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 42 seconds
Installing different package versions 9 minutes and 47 seconds
Running and plotting the test cases 2 minutes and 33 seconds

@MichaelChirico
Copy link
Member

Thanks! I will allow this to dwell for a while (say 3-6 months after the issue was posted) in case the original authors/pydatatable maintainers decide to weigh in

@badasahog
Copy link
Contributor Author

I think it can be confirmed by just looking at the code? It's pretty clear from the datatable codebase that the paths have diverged for some time now.

@MichaelChirico
Copy link
Member

I'm not sure if there's another repo (possibly private?) that has been split off

Copy link
Member

@ben-schwen ben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remnants of compatibility with python datatable library dilute code
3 participants