rolling prod more accurate #7351
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7349
while it feels ok for
adaptive=T/F
to have an impact on accuracy, thepartial=T/F
should not, and because of how partial is implemented, by redirect to adaptive, and because adaptive prod fast was suffering numerical stability due to cumulative prod (new tests added here also detects that), I decided to remove adaptive prod fast and use exact instead. Tips on possible implementation have been provided in the code.