-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix latest rchk issues #7585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix latest rchk issues #7585
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7585 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 87 87
Lines 16754 16803 +49
=======================================
+ Hits 16591 16640 +49
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Generated via commit 09d384c Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
ah, I forgot about reprotect too. let me try that later.
…On Sun, Jan 11, 2026, 9:37 AM Benjamin Schwendinger < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/rbindlist.c
<#7585 (comment)>
:
> @@ -303,7 +303,8 @@ SEXP rbindlist(SEXP l, SEXP usenamesArg, SEXP fillArg, SEXP idcolArg, SEXP ignor
if (isOrdered(thisCol)) {
orderedFactor = true;
int thisLen = length(getAttrib(thisCol, R_LevelsSymbol));
- if (thisLen>longestLen) { longestLen=thisLen; longestLevels=getAttrib(thisCol, R_LevelsSymbol); /*for warnings later ...*/longestW=w; longestI=i; }
+ if (longestLen == -1) longestLevels = PROTECT(R_NilValue);
seems we really need to go with the SEXP longestLevels =
PROTECT(R_NilValue); nprotect++
—
Reply to this email directly, view it on GitHub
<#7585 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2BA5JPX2MWY63O577QNHD4GKC5XAVCNFSM6AAAAACRJUWZ2CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNBYGE2TMNBVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks for jamming on this @ben-schwen! I always forget about |

Following kalibera/rchk#40,
rchkis showing some new uncaughtPROTECT()issues.