Skip to content

Conversation

@MichaelChirico
Copy link
Member

Following kalibera/rchk#40, rchk is showing some new uncaught PROTECT() issues.

@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (f3b166b) to head (09d384c).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7585   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          87       87           
  Lines       16754    16803   +49     
=======================================
+ Hits        16591    16640   +49     
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jan 11, 2026

  • HEAD=rchk slower P<0.001 for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit 09d384c

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 49 seconds
Installing different package versions 43 seconds
Running and plotting the test cases 4 minutes and 23 seconds

@MichaelChirico
Copy link
Member Author

MichaelChirico commented Jan 11, 2026 via email

@MichaelChirico
Copy link
Member Author

Thanks for jamming on this @ben-schwen! I always forget about REPROTECT(), it's clearly the "right" thing to do here. I think we are good to go now.

@ben-schwen ben-schwen merged commit 11a9435 into master Jan 11, 2026
13 checks passed
@ben-schwen ben-schwen deleted the rchk branch January 11, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants