fix(X / Twitter - Change Link Sharing Domain): Change link domain of share copy action #6091
Conversation
…e copy action Fixes #4259 Copied from nyraa@753921d (I don't know how to rescue the commit history, so pretend they were squished) Co-authored-by: nyraa <[email protected]> Co-authored-by: LisoUseInAIKyrios <[email protected]>
|
Does the share by menu work with the highest supported target? |
LisoUseInAIKyrios
changed the title
|
Oh yeah, I forgot about that. Will look into it. |
(this is an untested mess oh god)
|
Experimental resource patch replacement, if I'm correct this should remove the need for any bytecode patching at all (not sure if the "Copy link..." action uses the same resources) Now excuse me while I go figure out how the hell to test this |
|
Should be fully working now! |
patches/src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt
Outdated
Show resolved
Hide resolved
|
Is this patch for changing the domain of the link when we use "Copy link" and "Share via" or did I understood it wrong ? |
|
Yes, it is indeed that patch. |
|
Oh if that's the case, why make it too complicated, when we can use the same fingerprint that we are using for sanitizing the url, where Or did you find any drawback in this approach ? |
|
Modifying the resource is simple enough and it works. It may be more resilient than bytecode patching since resource names don't change often. |
|
Oh, but it might break at other areas like sharing profile, articles, searches, lists or is it that those are not the scope of the patch ? Edit: might also affect if we use the quick share app icons that are present at the bottom tray |
|
This specific resource is only used when sharing tweets (it specifies the |
|
Everything's fully functional according to my testing, so ye |
|
Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution. |
## [5.42.2-dev.2](v5.42.2-dev.1...v5.42.2-dev.2) (2025-10-10) ### Bug Fixes * **X / Twitter - Change Link Sharing Domain:** Change link domain of share copy action ([#6091](#6091)) ([5484625](5484625))
# [5.43.0](v5.42.1...v5.43.0) (2025-10-14) ### Bug Fixes * **Custom branding:** Use white notification icon for expanded status bar panel ([95eee59](95eee59)) * **Instagram - Change sharing domain:** Display patch option ([#6089](#6089)) ([be2b144](be2b144)) * **X / Twitter - Change Link Sharing Domain:** Change link domain of share copy action ([#6091](#6091)) ([5484625](5484625)) * **YouTube - Custom branding:** Do not add a broken custom icon if the user provides an invalid custom icon path ([6555f6e](6555f6e)) * **YouTube - Custom branding:** Use ReVanced icon for status bar notification icon ([#6108](#6108)) ([10ea250](10ea250)) * **YouTube - Force original audio:** Do not use translated audio if stream spoofing is off and force audio is on ([0c19dba](0c19dba)) ### Features * **Instagram:** Add `Hide suggested content` patch ([#6075](#6075)) ([50f0b9c](50f0b9c))
3 participants
"Rescued" from #5498 after the force push. See the original PR for details.
Shoutouts to @nyraa for the original PR!