-
Notifications
You must be signed in to change notification settings - Fork 19
feat: adding scopes to 'plugin list' and general cleanup #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: SequeI <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @SequeI, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the agentup plugin list command to enhance user experience and data output. It introduces a more intuitive two-step workflow, allowing users to first see a concise list of plugins and then drill down into detailed information, including capabilities and scopes, for a specific plugin. Furthermore, the JSON and YAML output formats have been redesigned to nest capabilities directly under their respective plugins, greatly improving data readability and programmatic parsing.
Highlights
- Enhanced 'plugin list' command: The agentup plugin list command now accepts an optional plugin_name argument, enabling users to retrieve detailed information and capabilities for a specific plugin, streamlining the inspection process.
- Improved JSON/YAML output format: The JSON and YAML output for plugin information has been restructured to embed capabilities directly within each plugin's data, making the output more logical, readable, and easier for automated parsing.
- Refactored capability display: The --capabilities flag's behavior has been updated to align with the new command flow, providing either a compact overview of all plugins with their capabilities or a detailed view for a single specified plugin.
- Code cleanup and helper functions: Several new internal helper functions (_format_capabilities, _format_plugin_data, _plugin_status, _print_no_plugins_message) have been introduced to modularize the plugin_info.py file, improving code maintainability and clarity.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the plugin list command to provide a more intuitive interface and cleaner output formats. The changes introduce a new argument to view details for a specific plugin and restructure the JSON/YAML output. My review found a critical bug that could cause the command to crash, along with some opportunities for improving type safety and test coverage. The refactoring is a good step forward, and addressing these points will make the implementation more robust.
Signed-off-by: SequeI <[email protected]>
Signed-off-by: SequeI <[email protected]>
Signed-off-by: SequeI <[email protected]>
|
Gemini comments resolved. |

name: 🛠️ Pull Request
📝 Description
The command flow has been redesigned to be more intuitive and efficient. Instead of a single command that provides a large, unwieldy output, the new approach uses a two-step process:
The main command lists all available plugins in a concise format. This allows users to quickly scan for plugins of interest.
Users can now use a specific plugin name as an argument to a new command to view a detailed breakdown of its capabilities and scopes. This is a more logical workflow, as it lets you inspect details only when you need them.
The output format for JSON and YAML has been completely refactored. Rather than listing capabilities separately, they are now directly nested under the plugin to which they belong. This new hierarchy is beneficial for two main reasons:
Readability: The data is much easier to read and understand, as it creates a clear relationship between a plugin and what it can do.
Parsing: The nested structure is standard for data formats like JSON and YAML, making it significantly easier for scripts and other applications to parse the output.
🔍 Related Issues
Closes #84