Skip to content

Conversation

@GuilhermeGabriel
Copy link
Contributor

@GuilhermeGabriel GuilhermeGabriel commented Jan 23, 2024

Description

In the demo environment there’s a bug setting filters for the records of a resource question:

Form: Teachers

location_states (name of the question in the resource)
location_states_teacher (question to filter by)

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Selecting a specific state and seeing if it show schools only from that state.

Screenshots

output.mp4

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@GuilhermeGabriel GuilhermeGabriel added the bug Something isn't working label Jan 23, 2024
@GuilhermeGabriel GuilhermeGabriel self-assigned this Jan 23, 2024
@GuilhermeGabriel GuilhermeGabriel marked this pull request as ready for review January 23, 2024 19:12
@GuilhermeGabriel GuilhermeGabriel marked this pull request as draft January 23, 2024 19:13
@GuilhermeGabriel GuilhermeGabriel requested review from matheus-relief and removed request for matheus-relief January 23, 2024 19:13
@GuilhermeGabriel GuilhermeGabriel marked this pull request as ready for review January 23, 2024 19:15
Copy link
Contributor

@matheus-relief matheus-relief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuilhermeGabriel The problem seems to be that we are not able to set the filters, so instead of sending a default operator, we should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants