Skip to content

feat/HIT-281-Change-of-field-names-applied-in-layouts-and-aggregations #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next-oort
Choose a base branch
from
Open

feat/HIT-281-Change-of-field-names-applied-in-layouts-and-aggregations #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b658a96
feat: field/question name is now editable
estelafs May 24, 2024
b4bbd08
don't always set oldName property
estelafs Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libs/shared/src/lib/survey/creator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { Question } from './types';
export const initCreatorSettings = (): void => {
const serializer: JsonMetadata = Serializer;

serializer.findProperty('question', 'name').readOnly = true;
serializer.findProperty('question', 'name').onGetValue = (obj: Question) =>
obj.valueName ? obj.valueName : obj.name;
serializer.findProperty('question', 'valueName').isRequired = true;
Expand Down
18 changes: 18 additions & 0 deletions libs/shared/src/lib/survey/global-properties/others.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,24 @@ export const init = (environment: any): void => {
}
return newValue;
};
// When updating the question name, we need to inform that's a new name
Serializer.addProperty('question', {
name: 'oldName',
visible: false,
});
// When updating the question name, sets the question valueName as well
serializer.getProperty('question', 'name').onSettingValue = (
question: Question,
newValue: string
) => {
if (newValue && question.name && newValue !== question.name) {
question.setPropertyValue('oldName', question.name);
} else {
question.setPropertyValue('oldName', undefined);
}
question.setPropertyValue('valueName', newValue);
return newValue;
};
// Adds valueExpression to questions, that when set pretty much transforms it into an expression question
// whilst still keeping normal question behaviors
Serializer.addProperty('question', {
Expand Down