-
Notifications
You must be signed in to change notification settings - Fork 0
feat/HIT-335 Add optional new style to sidebar #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next-oort
Are you sure you want to change the base?
feat/HIT-335 Add optional new style to sidebar #98
Conversation
…le update on application settings save feat: add application name display, logo and ui dividers for the sidenav with "new" variant type feat: update application settings form in order to be in compliance with the relation between sideMenu and variant. If sideMenu is disabled, then variant value is cleaned and field is also disabled refactor: duplicated SidenavVariantsTypes type from application.model, instead use the one set in the sidenavs.ts fix: dashboard state dialog close when no data is set by filtering content on dialog closed subscription
|
@matheus-relief Last commit Things to take in account
About this buttons there is nothing specified in the ticket or figma Those should have to be addressed in order to be in compliance with the figma design |
…-frontend into HIT_335-New-optional-design-for-sidebar
* add divider to resources button * add divider to dashboard state action button
…cloak docker (#115) HIT-373
Merge main into HIT-335
…design-for-sidebar
|
Implemented upload logo feature for front-end and back-end.
|
|
Completed the sidenav. Last notes:
tested on chrome and firefox Untitled-application-0.webm |







Description
Started the implementation of the new design for the sidebars in oort.
The majority of the design has been implemented, but the top corner logo. It still uses the old layout with the top bar "on top" of the sidebar, as it is the one that has access to the options / toggle, name and filtering.
Icons are still the same ones, as the set hasn't been provided.
New setting has been added to the applications settings page to toggle the new style.
Implementation
shared-navbar & shared-layout components have been updated to accept a 'variant' Input. This input accepts 'original' and 'new' as variables, defaulting as 'original'. The 'new' variable makes the sidebar use the new design.
Another variable has been added to shared-navbar called 'bottomOptions', which is used to pass the app options (normally available from the top button) to the navbar, relevant for the new design.
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Screenshots
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145