Multi-period (tar.gz) file extensions fix for extract_artifact! #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archives with multi-period extensions (like
tar.gzfor example) are not matched correctly by theextract_artifact!method.The problem with the actual implementation is that
::File.extname()for a multi-period filename extension doesn't extract all the part but only the last unique extension after the last..For instance :
foo.tar.gzgets an extension.gzinstead of.tar.gz.The use of an heuristic is necessary to guess the real extension. This heuristic is done inside the new
extname()function.For this correction, this function will return :