Skip to content

Conversation

@smitjiwani
Copy link

Changes introduced

I have incorporated support for .png, .jpg, and other media file types to enhance asset management and integration within the project. Additionally, a parser has been implemented for asset/resource and asset/inline, streamlining the handling and embedding of assets and resources directly within the application. Furthermore, I have integrated the MiniCssExtractPlugin into the Webpack 5 configuration. This integration facilitates efficient CSS extraction during the bundling process, optimizing the performance and load times of our web assets.

Dependencies

npm i mini-css-extract-plugin --save-dev

…sourse or asset/inline. Added MiniCssExtractPlugin.
@CulturalProfessor
Copy link
Collaborator

hey @smitjiwani this is the webpack file we use for bundling client/webpack.config.js

@smitjiwani
Copy link
Author

Okay @CulturalProfessor should I add the enhancements to ./client/webpack.config.js for review?

@smitjiwani smitjiwani deleted the branch RocketChat:main December 27, 2023 16:20
@smitjiwani smitjiwani closed this Dec 27, 2023
@smitjiwani smitjiwani deleted the main branch December 27, 2023 16:20
@smitjiwani smitjiwani restored the main branch December 27, 2023 16:21
…sourse or asset/inline. Added MiniCssExtractPlugin. v2
@smitjiwani smitjiwani reopened this Dec 28, 2023
@smitjiwani smitjiwani closed this Dec 28, 2023
@smitjiwani smitjiwani reopened this Dec 28, 2023
@CulturalProfessor
Copy link
Collaborator

Okay @CulturalProfessor should I add the enhancements to ./client/webpack.config.js for review?

yes to try if they work add changes there and run build commands

@smitjiwani
Copy link
Author

smitjiwani commented Dec 30, 2023

Yes, I have done that in 0cd6529and to test the changes for prod --mode production can be used. I plan on adding more changes to the file. Also we should make separate files for dev and prod respectively.

@CulturalProfessor
Copy link
Collaborator

CulturalProfessor commented Dec 30, 2023

see if the font issue is not due to webpack not including it also #26

@smitjiwani
Copy link
Author

These two resources might help us solve the font problem. Just keeping them here so that i don't forget...

https://webpack.js.org/configuration/output/#outputassetmodulefilename
https://webpack.js.org/guides/asset-modules/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants