Skip to content

Conversation

@brf153
Copy link
Contributor

@brf153 brf153 commented Jan 6, 2024

No description provided.

@brf153
Copy link
Contributor Author

brf153 commented Jan 6, 2024

@CulturalProfessor for search functionality, should I add the feature that when we are searching the board, we render a new board with searched board's data and configurations and delete the initial board? Which means that lets say I created an initial board with the name bhandari. Then someone searches for that board and we render a new board which contains all the data of the board with the name bhandari and delete the board which was initially created with the name bhandari. The newly rendered board wilil look and work in the same way as that of the initial board. It is just that we would not have multiple boards in the room which searching for a board.

@CulturalProfessor
Copy link
Collaborator

@CulturalProfessor for search functionality, should I add the feature that when we are searching the board, we render a new board with searched board's data and configurations and delete the initial board? Which means that lets say I created an initial board with the name bhandari. Then someone searches for that board and we render a new board which contains all the data of the board with the name bhandari and delete the board which was initially created with the name bhandari. The newly rendered board wilil look and work in the same way as that of the initial board. It is just that we would not have multiple boards in the room which searching for a board.

yeah but in this case we're deleting original message along with any critical info in it maybe in a form of thread or reactions .

So a better way might be if we can quote the original message as a notification so user can jump back to it

@brf153
Copy link
Contributor Author

brf153 commented Jan 6, 2024

Oki will quote the message

@brf153
Copy link
Contributor Author

brf153 commented Jan 7, 2024

@CulturalProfessor please can you tell me how to quote a message? I am not being able to find the function.

Signed-off-by: brf153 <[email protected]>
@brf153
Copy link
Contributor Author

brf153 commented Jan 14, 2024

@CulturalProfessor, I think this is a good approach.

WhatsApp.Video.2024-01-14.at.11.39.37.mp4

@brf153 brf153 marked this pull request as ready for review January 14, 2024 06:43
@CulturalProfessor
Copy link
Collaborator

@CulturalProfessor, I think this is a good approach.

WhatsApp.Video.2024-01-14.at.11.39.37.mp4

Hey @brf153 it seems a good approach see if we can open the button link in same tab

@brf153
Copy link
Contributor Author

brf153 commented Jan 18, 2024

@CulturalProfessor actually I checked it. One way that I got is to refresh the page when the user clicks on the board. I don't think it is a good approach.

I think this approach is better because lets say that if the board is way up in the room then the user might have to scroll down again or refresh or do something equivalent to come back to the latest message. But with this approach the user can directly access the board. After accessing the board he can simply close the tab and he would see the latest message.

@brf153
Copy link
Contributor Author

brf153 commented Jan 27, 2024

@CulturalProfessor Should I make any additional modifications to this pull request? Would you like me to alter the approach?

Signed-off-by: brf153 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants