-
Notifications
You must be signed in to change notification settings - Fork 40
feat: adding search command #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: brf153 <[email protected]>
Signed-off-by: brf153 <[email protected]>
Signed-off-by: brf153 <[email protected]>
Signed-off-by: brf153 <[email protected]>
Signed-off-by: brf153 <[email protected]>
|
@CulturalProfessor for search functionality, should I add the feature that when we are searching the board, we render a new board with searched board's data and configurations and delete the initial board? Which means that lets say I created an initial board with the name bhandari. Then someone searches for that board and we render a new board which contains all the data of the board with the name bhandari and delete the board which was initially created with the name bhandari. The newly rendered board wilil look and work in the same way as that of the initial board. It is just that we would not have multiple boards in the room which searching for a board. |
yeah but in this case we're deleting original message along with any critical info in it maybe in a form of thread or reactions . So a better way might be if we can quote the original message as a notification so user can jump back to it |
|
Oki will quote the message |
|
@CulturalProfessor please can you tell me how to quote a message? I am not being able to find the function. |
Signed-off-by: brf153 <[email protected]>
|
@CulturalProfessor, I think this is a good approach. WhatsApp.Video.2024-01-14.at.11.39.37.mp4 |
Signed-off-by: brf153 <[email protected]>
Hey @brf153 it seems a good approach see if we can open the button link in same tab |
|
@CulturalProfessor actually I checked it. One way that I got is to refresh the page when the user clicks on the board. I don't think it is a good approach. I think this approach is better because lets say that if the board is way up in the room then the user might have to scroll down again or refresh or do something equivalent to come back to the latest message. But with this approach the user can directly access the board. After accessing the board he can simply close the tab and he would see the latest message. |
Signed-off-by: brf153 <[email protected]>
|
@CulturalProfessor Should I make any additional modifications to this pull request? Would you like me to alter the approach? |
Signed-off-by: brf153 <[email protected]>
No description provided.