[NOMERGE]: tests failing on github actions

[OtavioStasiak]

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

• Tests
  • Enhanced internationalization test coverage with a new Dutch language verification sequence to confirm proper UI text translation, labels, and menu items in the Dutch locale.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The i18n test file is updated to add Dutch language test coverage. A new test sequence for the "nl" locale is inserted that verifies Dutch-translated UI elements including labels and menu items. The drawer close action is repositioned to execute after this new test block rather than before it.

Changes

Cohort / File(s)	Summary
i18n Test Enhancement .maestro/tests/assorted/i18n.yaml	Adds Dutch (nl) language test sequence with UI text verification; reorders drawer close action to execute after the new language test block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A polyglot bunny hops with glee,
Testing Dutch words—eel, twee, drie!
The drawer closes, translations flow,
Each language verified high and low. ✨🇳🇱

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title '[NOMERGE]: tests failing on github actions' is vague and does not clearly describe the actual changes made to the codebase, which involve adding an i18n test sequence for Dutch language support in the test file.	Clarify the title to reflect the actual changes (e.g., 'Add Dutch (NL) i18n test sequence' or 'Add i18n test for Dutch language support') rather than using a generic '[NOMERGE]' placeholder that does not convey meaningful information about the changeset.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch NOMERGE-test-e2e

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0d13c14 and ff31be9.

📒 Files selected for processing (1)

• .maestro/tests/assorted/i18n.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ESLint and Test / run-eslint-and-test

🔇 Additional comments (1)

.maestro/tests/assorted/i18n.yaml (1)

49-76: The mixed language expectations are intentional and correct—no changes needed to the test assertions.

The test demonstrates i18n fallback behavior: 'Chats' has no Dutch translation in app/i18n/locales/nl.json, so it correctly falls back to English, while 'Profiel' and 'Instellingen' use their Dutch translations. The comment "should select 'nl' and fallback to 'en'" accurately describes this behavior.

Note: The test is marked as failing on line 48. If the failure is unrelated to the assertions, investigate the actual cause of the test failure (e.g., UI element availability, timing, or other flow issues).

Optional: The Dutch test (lines 49–76) duplicates the structure of the English test (lines 20–47). Consider extracting a reusable flow that accepts language code and expected text values as parameters.

Likely an incorrect or invalid review comment.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n .maestro/tests/assorted/i18n.yaml | head -80

Repository: RocketChat/Rocket.Chat.ReactNative

Length of output: 2285

---

🏁 Script executed:

# Check if there's a git history or related issues
git log --oneline -20 -- .maestro/tests/assorted/i18n.yaml 2>/dev/null | head -10

Repository: RocketChat/Rocket.Chat.ReactNative

Length of output: 99

---

🏁 Script executed:

# Check for any setup issues with language navigation
cat -n .maestro/tests/assorted/utils/nav-to-language.yaml

Repository: RocketChat/Rocket.Chat.ReactNative

Length of output: 1194

---

Investigate the failing Dutch language fallback test.

The test starting at line 49 checks i18n fallback behavior when Dutch is selected (it intentionally expects mixed English and Dutch text based on the fallback mechanism noted in the comment). However, the test is failing. Determine the specific point of failure—which element is not appearing, timeout, or other issue—and either fix the implementation or adjust the test expectations accordingly.

[github-actions]

Android Build Available

Rocket.Chat Experimental 4.68.0.107954

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNQGU5FsBxZQkHwImt1IKkUyn37UBehlczXkpqQsAR60Sn_iGNaxa-IVWlCplY4noM1zxpdMHzWrsjXPOHWJ

[github-actions]

iOS Build Available

Rocket.Chat Experimental 4.68.0.107955