Skip to content

Conversation

ArthurJWH
Copy link
Contributor

@ArthurJWH ArthurJWH commented Oct 3, 2025

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The axis use North and East as labels
Screenshot 2025-10-05 170136

New behavior

Label the extremes of the axis as North-South and West-East
Screenshot 2025-10-05 165426

Breaking change

  • Yes
  • No

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurJWH the PR is simple and straightforward, thx for that!

  1. Could you provide us a screenshot of your results please? This makes review easier since I won't have to run several simulations to obtain the new plots.
  2. Could you kindly update the CHANGELOG pls?

After these 2 points, I believe we will merge it directly.

@ArthurJWH ArthurJWH self-assigned this Oct 5, 2025
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.28%. Comparing base (f17893b) to head (6713f0b).
⚠️ Report is 26 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #855      +/-   ##
===========================================
+ Coverage    80.02%   80.28%   +0.26%     
===========================================
  Files           98      104       +6     
  Lines        12004    12764     +760     
===========================================
+ Hits          9606    10248     +642     
- Misses        2398     2516     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gui-FernandesBR Gui-FernandesBR force-pushed the enh/changing-ellipses-axis-label branch from 3bbe340 to 6713f0b Compare October 8, 2025 15:47
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurJWH friendly reminder to update the CHANGELOG pls

@github-project-automation github-project-automation bot moved this from Backlog to Next Version in LibDev Roadmap Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Next Version

Development

Successfully merging this pull request may close these issues.

2 participants