Skip to content

Use GCC 15 to compile when checking for warnings #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Use GCC 15 to compile when checking for warnings #3833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
17d53ec
Use GCC 15 to compile when checking for warnings
powerboat9 Jun 17, 2025
54859c5
Revert "Use GCC 15 to compile when checking for warnings"
powerboat9 Jun 18, 2025
90d3d3f
use containers
powerboat9 Jun 18, 2025
e13bd54
install curl
powerboat9 Jun 18, 2025
107c426
add cargo to path during configure
powerboat9 Jun 18, 2025
93aa1d4
remove sudo
powerboat9 Jun 18, 2025
94ffd1a
set noninteractive
powerboat9 Jun 18, 2025
d187c98
unshare user
powerboat9 Jun 18, 2025
8857d3b
adjust expected warnings
powerboat9 Jun 18, 2025
ba10eb1
remove unshare
powerboat9 Jun 18, 2025
e9b4764
disable networking
powerboat9 Jun 18, 2025
b0a8c7b
update ubuntu
powerboat9 Jun 18, 2025
fb1d902
fixup networking patch
powerboat9 Jun 18, 2025
525f258
install nftables
powerboat9 Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/glibcxx_ubuntu64b_log_expected_warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,8 @@
../../libcpp/macro.cc:214:34: warning: format not a string literal and no format arguments [-Wformat-security]
../../libcpp/macro.cc:3811:25: warning: format not a string literal and no format arguments [-Wformat-security]
../../libcpp/macro.cc:3826:25: warning: format not a string literal and no format arguments [-Wformat-security]
/home/runner/work/gccrs/gccrs/gccrs-build/x86_64-pc-linux-gnu/32/libssp/../../../../libssp/gets-chk.c:73: warning: the `gets' function is dangerous and should not be used.
/home/runner/work/gccrs/gccrs/gccrs-build/x86_64-pc-linux-gnu/libssp/../../../libssp/gets-chk.c:73: warning: the `gets' function is dangerous and should not be used.
/__w/gccrs/gccrs/gccrs-build/x86_64-pc-linux-gnu/32/libssp/../../../../libssp/gets-chk.c:73: warning: the `gets' function is dangerous and should not be used.
/__w/gccrs/gccrs/gccrs-build/x86_64-pc-linux-gnu/libssp/../../../libssp/gets-chk.c:73: warning: the `gets' function is dangerous and should not be used.
gengtype-lex.cc:357:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
gengtype-lex.cc:357:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
gengtype-lex.cc:357:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
Expand Down
4 changes: 2 additions & 2 deletions .github/log_expected_warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,8 @@
../../libcpp/macro.cc:214:34: warning: format not a string literal and no format arguments [-Wformat-security]
../../libcpp/macro.cc:3811:25: warning: format not a string literal and no format arguments [-Wformat-security]
../../libcpp/macro.cc:3826:25: warning: format not a string literal and no format arguments [-Wformat-security]
/home/runner/work/gccrs/gccrs/gccrs-build/x86_64-pc-linux-gnu/32/libssp/../../../../libssp/gets-chk.c:73: warning: the `gets' function is dangerous and should not be used.
/home/runner/work/gccrs/gccrs/gccrs-build/x86_64-pc-linux-gnu/libssp/../../../libssp/gets-chk.c:73: warning: the `gets' function is dangerous and should not be used.
/__w/gccrs/gccrs/gccrs-build/x86_64-pc-linux-gnu/32/libssp/../../../../libssp/gets-chk.c:73: warning: the `gets' function is dangerous and should not be used.
/__w/gccrs/gccrs/gccrs-build/x86_64-pc-linux-gnu/libssp/../../../libssp/gets-chk.c:73: warning: the `gets' function is dangerous and should not be used.
gengtype-lex.cc:357:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
gengtype-lex.cc:357:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
gengtype-lex.cc:357:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
Expand Down
53 changes: 40 additions & 13 deletions .github/workflows/ccpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,17 @@ jobs:
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
LC_ALL: C.UTF-8

runs-on: ubuntu-22.04
runs-on: ubuntu-latest
container: ubuntu:25.04

steps:
- uses: actions/checkout@v4

- name: Install Deps
run: |
sudo apt-get update;
sudo apt-get install -y \
apt-get update;
DEBIAN_FRONTEND=noninteractive \
apt-get install -y \
automake \
autoconf \
libtool \
Expand All @@ -40,17 +42,24 @@ jobs:
build-essential \
gcc-multilib \
g++-multilib \
dejagnu;
dejagnu \
curl \
nftables;
# install Rust directly using rustup
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain=1.72.0;

- name: Disable Networking
run: nft add rule filter output drop

- name: Make Source Read-Only
run: chmod -R a-w ./*

- name: Configure
run: |
mkdir -p gccrs-build;
cd gccrs-build;
# Add cargo to our path quickly
. "$HOME/.cargo/env";
../configure \
--enable-languages=rust \
--disable-bootstrap \
Expand All @@ -63,7 +72,7 @@ jobs:
# Add cargo to our path quickly
. "$HOME/.cargo/env"; \
# Build without network access
unshare --net --ipc -r /bin/bash -c "make -Otarget -j $(nproc) 2>&1 | tee log ; exit \${PIPESTATUS[0]}"
make -Otarget -j $(nproc) 2>&1 | tee log

- name: Check for new warnings
run: |
Expand Down Expand Up @@ -104,15 +113,17 @@ jobs:
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
LC_ALL: C.UTF-8

runs-on: ubuntu-22.04
runs-on: ubuntu-latest
container: ubuntu:25.04

steps:
- uses: actions/checkout@v4

- name: Install Deps
run: |
sudo apt-get update;
sudo apt-get install -y \
apt-get update;
DEBIAN_FRONTEND=noninteractive \
apt-get install -y \
automake \
autoconf \
libtool \
Expand All @@ -125,17 +136,24 @@ jobs:
build-essential \
gcc-multilib \
g++-multilib \
dejagnu;
dejagnu \
curl \
nftables;
# install Rust directly using rustup
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain=1.72.0;

- name: Disable Networking
run: nft add rule filter output drop

- name: Make Source Read-Only
run: chmod -R a-w ./*

- name: Configure
run: |
mkdir -p gccrs-build;
cd gccrs-build;
# Add cargo to our path quickly
. "$HOME/.cargo/env";
export CXXFLAGS="$CXXFLAGS -D_GLIBCXX_ASSERTIONS"
../configure \
--enable-languages=rust \
Expand Down Expand Up @@ -189,15 +207,17 @@ jobs:
# Force locale, in particular for reproducible results re '.github/log_expected_warnings' (see below).
LC_ALL: C.UTF-8

runs-on: ubuntu-22.04
runs-on: ubuntu-latest
container: ubuntu:25.04

steps:
- uses: actions/checkout@v4

- name: Install Deps
run: |
sudo apt-get update;
sudo apt-get install -y \
apt-get update;
DEBIAN_FRONTEND=noninteractive \
apt-get install -y \
automake \
autoconf \
libtool \
Expand All @@ -210,17 +230,24 @@ jobs:
build-essential \
gcc-multilib \
g++-multilib \
dejagnu;
dejagnu \
curl \
nftables;
# install Rust directly using rustup
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain=1.72.0;

- name: Disable Networking
run: nft add rule filter output drop

- name: Make Source Read-Only
run: chmod -R a-w ./*

- name: Configure
run: |
mkdir -p gccrs-build;
cd gccrs-build;
# Add cargo to our path quickly
. "$HOME/.cargo/env";
../configure \
--enable-languages=rust \
--disable-bootstrap \
Expand Down
Loading