Add derived set to collect derived nodes. #4047
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerboat9
reviewed
Aug 8, 2025
gcc/rust/util/rust-hir-map.cc
Outdated
| @@ -1358,5 +1358,17 @@ Mappings::lookup_captures (NodeId closure) | |||
| return cap->second; | |||
| } | |||
|
|
|||
| void | |||
| Mappings::add_derived_nodes (NodeId node_id) | |||
There was a problem hiding this comment.
Should probably be add_derived_node (not plural)
|
Otherwise, looks good |
gcc/rust/ChangeLog: * expand/rust-expand-visitor.cc (builtin_derive_item): Collect derived nodes. (derive_item): Collect derived nodes. * util/rust-hir-map.cc (Mappings::add_derived_nodes): Add derived set to collect derived nodes. (Mappings::is_derived_node): Add derived set to collect derived nodes. * util/rust-hir-map.h: Add derived set to collect derived nodes. Signed-off-by: Ryutaro Okada <[email protected]>
sakupan102
force-pushed
the
add-derived-nodes
branch
from
9ae9ba7 to
6f0d32b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding
derivedflag to AST node, I use a set to collect derived nodes. I distinguish between items that are automatically generated by #[derive()] and those that aren't with this set.old PR: #4028
make check-rustpasses locally