Keep deprecated feature flag oboe-shared-stdcxx to avoid breaking change
#977
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
est31
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#961 removed the feature flag, which is a shame, because that means the next
cpalrelease will be a breaking change. I'd like to get #943 out sooner rather than later (to fix the issues Bevy and others are experiencing withbindgenand the iOS simulator), .So this PR re-adds the feature flag, but with a comment that it is deprecated.
One could argue that changing the backend itself is a breaking change because of the minimum supported version bump. I will argue that it is not, as there is precedent for such bumps in
rustcas well, see e.g. this and this, and disallowing such things in non-breaking versions makes it effectively impossible forcpalto ever reach a stablev1.0.