fix: minimp3 decoder compilation #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CI check for minimp3 feature and update mp3 decoder to use Sample type instead of DecoderSample.
roderickvd
force-pushed
the
fix/minimp3-decoder
branch
from
0db7bd4 to
126e8c6
Compare
dvdsk
approved these changes
Jun 10, 2025
|
Thanks! Are the other decoders tested by default? |
Yes, because they are enabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A last-minute one as I was preparing another PR for a release beyond 0.21: the
minimp3decoder is broken. This PR fixes that and adds a CI check to prevent regression.