Add Jacobi symbol calculation #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
feat/jacobi-symbol
branch
from
3580460 to
a56616a
Compare
|
@erik-3milabs can you take a look at the |
fjarri
reviewed
Aug 18, 2025
fjarri
reviewed
Aug 18, 2025
fjarri
reviewed
Aug 18, 2025
fjarri
reviewed
Aug 18, 2025
fjarri
reviewed
Aug 18, 2025
fjarri
reviewed
Aug 18, 2025
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
tarcieri
reviewed
Aug 27, 2025
| @@ -0,0 +1,63 @@ | |||
| //! Modular symbol calculation for integers in Montgomery form with a constant modulus. | |||
There was a problem hiding this comment.
Nit: isn't the mod_ part implied by this being in modular?
There was a problem hiding this comment.
I suppose so, but it's consistent with uint/mod_symbol and int/mod_symbol
tarcieri
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is based on
bingcd. It does not appear to affect the GCD performance, being optimized away when it is not needed. This would be useful inprimefieldfor addingis_square/is_square_vartimemethods which should be faster thansqrt.