Faster wrapping multiplication #930
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements basic wrapping multiplication for
Uint
andBoxedUint
, deferring to Karatsuba multiplication when it would be faster (estimated by benchmarks). The number of limbs needs to get fairly high before it needs to switch over though, andUint
currently only implements Karatsuba for a few limb counts that are powers of two (I also have aconst
implementation that might help with that).A few relevant benchmarks: