Allow serde without alloc
#1972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdenkikniet
force-pushed
the
no-alloc-serde
branch
from
b562e4c to
fc67af8
Compare
datdenkikniet
commented
Aug 24, 2025
| @@ -436,6 +458,7 @@ where | |||
| let public_key_bytes = self.to_encoded_point(false); | |||
| let subject_public_key = der::asn1::BitStringRef::new(0, public_key_bytes.as_bytes())?; | |||
|
|
|||
| // TODO: use `encode_as_der` here? | |||
There was a problem hiding this comment.
Using encode_as_der seemed like a hassle here. Is there a better approach than encode_as_der followed directly by Document::decode().unwrap()?
Also suffers from the encoding length question, and this specific conversion will require alloc anyways (because der::Document contains a Vec<u8>)
| @@ -483,7 +506,11 @@ where | |||
| where | |||
| S: ser::Serializer, | |||
| { | |||
| let der = self.to_public_key_der().map_err(ser::Error::custom)?; | |||
| // TODO: can we determine DER encoding length up-front? Using `MockCurve` gives | |||
There was a problem hiding this comment.
Is there a way to collect this information from some associated const? Was hard to figure out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1960, supersedes #1962
I've tried my best to dig into the associated parts here, and it seems that the
der::Documentencoding used as intermediate step is the culprit.Sadly I don't have enough insight to validate my TODO's. Will leave separate comments on those that I hope RustCrypto maintainers have better answers to.