Skip to content

Conversation

cernus76
Copy link
Contributor

@navyakhurana @julian-schambeck @jmsrpp

As we have a regression with the new version of drawio, I have created a script to check the drawio files to see if there are external references via image=http references.

We could probably include this in a pre-check when a user submits a file.

Usage:
./src/_scripts/_validate_drawio_external_refs.zsh <path_of_the_ref-arch_folder>

Example:
./src/_scripts/_validate_drawio_external_refs.zsh /Users/<my_user_id>/architecture-center/docs

Output:

Scanning drawio files for external image references (image=http patterns)...
============================================================================
Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0004/1-aws-data-integration/drawio/aws-data-integration.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0004/drawio/explore-hyperscaler-data.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0004/2-azure-data-integration/drawio/azure-data-integration.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0004/4-gcp-data-integration/drawio/gcp-data-integration.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0004/3-databricks-data-integration/drawio/databricks-data-integration.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0003/fedml-azure/drawio/fedml-azure.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0003/fedml-gcp/drawio/fedml-gcp.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0003/fedml-databricks/drawio/fedml-databricks.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0003/fedml-watsonx/drawio/fedml-watson.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0003/fedml-aws/drawio/fedml-aws.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0003/drawio/fedml-final.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0003/fedml-nvidia/drawio/fedml-nvidia.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0002/1-fundamentals/1-single-region-resiliency/drawio/multi-az.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0002/5-event-synchronization/drawio/event-replication.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0002/6-control-plane/drawio/multi-region-manager.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0002/4-data-synchronization/drawio/data-replication.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0002/drawio/architecting-multi-region-resiliency-for-sap-btp-use-cases.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0002/2-geographic-redundancy/drawio/geographic-redundancy.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0002/3-loadbalancers/drawio/loadbalancer.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/2-semantic-search/drawio/reference-architecture-generative-ai-semantic-search.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/6-agents-structured-data/drawio/reference-architecture-generative-ai-intelligent-data-apps.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/10-vibe-code-with-cline/drawio/cline-vibe-code-diagram.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/5-ai-agents/drawio/reference-architecture-generative-ai-code-based.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/1-basics/drawio/reference-architecture-generative-ai-basic.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/drawio/reference-architecture-generative-ai.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/8-agent2agent-interoperability/drawio/a2a-ard-l1.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/3-retrieval-augmented-generation/drawio/reference-architecture-generative-ai-rag.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0005/9-partner-models/drawio/ibm-granite-rag-ard.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0018/drawio/integrate-and-extend-with-sap-build-process-automation.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0020/drawio/business-to-business-integration.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0016/2-secure-service-consumption-on-gcp/drawio/gcp-oidc.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0016/drawio/oidc-sts.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0016/drawio/iam-roles-anywhere.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0016/drawio/gcp-oidc.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0016/1-secure-service-consumption-on-aws/drawio/oidc-sts.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0016/1-secure-service-consumption-on-aws/drawio/iam-roles-anywhere.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0011/drawio/esri-and-hana-cloud.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0010/drawio/sap-build-work-zone.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0017/drawio/master-data-integration.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0021/drawio/application-to-application-integration.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/1-authentication-and-single-sign-on/drawio/public-sap-authn-sd.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/2-identity-lifecycle/drawio/public-sap-identity-lifecycle-sd.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/4-Joule IAM/drawio/public-sap-iam-joule-sd-cdm.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/4-Joule IAM/drawio/public-sap-iam-joule-sd.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/4-Joule IAM/drawio/public-sap-iam-joule-sd-authz.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/4-Joule IAM/drawio/public-sap-iam-joule-sd-authn.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/4-Joule IAM/drawio/public-sap-iam-joule-sd-user.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/drawio/public-sap-iam-sd.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0019/3-authorization-design/drawio/public-sap-authz-sd.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0000/drawio/demo.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0007/5-mt-architecture/drawio/susaas-app-architecture.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0009/drawio/establish-a-central-inbox-with-sap-task-center.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0008/drawio/sap_eic.drawio
  ❌ ERROR: External image reference found!
  📍 Found external references in these locations:
    Line: 140:        <mxCell id="GK1j6T8cdDNpq15kFjSn-72" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://cdn0.iconfinder.com/data/icons/buno-security-2/32/__virtual_private_cloud-512.png;" parent="1" vertex="1">
    Line: 160:        <mxCell id="GK1j6T8cdDNpq15kFjSn-78" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://upload.wikimedia.org/wikipedia/commons/thumb/9/93/Amazon_Web_Services_Logo.svg/1024px-Amazon_Web_Services_Logo.svg.png;" parent="1" vertex="1">
    Line: 163:        <mxCell id="GK1j6T8cdDNpq15kFjSn-80" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://logos-world.net/wp-content/uploads/2021/02/Google-Cloud-Logo.png;" parent="1" vertex="1">
    Line: 181:        <mxCell id="c7ha8ujQYmhdGz0n4e6j-57" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://seekvectors.com/files/download/Sap-01.png;" parent="2HGDGh5_L6hypmfTz_1F-5" vertex="1">
    Line: 196:        <mxCell id="2HGDGh5_L6hypmfTz_1F-11" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://seekvectors.com/files/download/Sap-01.png;" parent="2HGDGh5_L6hypmfTz_1F-8" vertex="1">

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0008/2-edge-integration-cell-on-azure/drawio/sap-edge-integration-cell-azure.drawio
  ❌ ERROR: External image reference found!
  📍 Found external references in these locations:
    Line: 13:        <mxCell id="81On1e0Q9KAB1Wue_lXp-3" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://swimburger.net/media/ppnn3pcl/azure.png;" vertex="1" parent="81On1e0Q9KAB1Wue_lXp-1">
    Line: 322:        <mxCell id="81On1e0Q9KAB1Wue_lXp-85" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://symbols.getvecta.com/stencil_28/71_virtual-network.8cd684329b.png;" vertex="1" parent="1">
    Line: 377:        <mxCell id="81On1e0Q9KAB1Wue_lXp-101" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://static-00.iconduck.com/assets.00/azure-subscription-icon-512x379-cq3ioz2s.png;" vertex="1" parent="1">

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0008/3-edge-integration-cell-on-gcp/drawio/sap-edge-integration-cell-gcp.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0008/1-edge-integration-cell-on-aws/drawio/sap-edge-integration-cell-aws.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0006/drawio/secure-connectivity-with-sap-private-link-service.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/3-aws-iot-integration/drawio/e2b-awsiot-pl.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/3-aws-iot-integration/drawio/e2b-awsiot-cc.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/3-aws-iot-integration/drawio/e2b-awsiot-sqs.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/3-aws-iot-integration/drawio/e2b-awsiotsitewise-pl.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/drawio/e2b-cc.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/drawio/e2b-privatelink.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/4-azure-iot-integration/drawio/e2b-azure-pl.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/4-azure-iot-integration/drawio/e2b-azure-cc.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0001/2-design-considerations/drawio/e2b-cc.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0023/drawio/devops-with-sap-btp.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0024/drawio/joule-studio-ref-arch.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0012/drawio/medallion-big-data-architecture.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0015/drawio/business-to-government-integration.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0014/drawio/measurement_landscape.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0014/drawio/Direct_OData_Call.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0014/drawio/OData_Call_CAP_PrivateLink.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0014/drawio/OData_Call_App_Router_PrivateLink.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0014/drawio/OData_Call_App_Router.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0014/drawio/OData_Call_App_Router_SCC.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0014/drawio/OData_Call_CAP_App.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0014/drawio/OData_Call_CAP_SCC.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/1-data-products-in-sap-business-data-cloud/drawio/bdc-dataproduct1.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/drawio/sap-bdc.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/5-sap-databricks-in-business-data-cloud/drawio/bdc-databricks.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/5-sap-databricks-in-business-data-cloud/drawio/bdc-databricks-brownfield.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/3-intelligent-applications-greenfield-bdc/drawio/sap-managed-intelligent-application.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/3-intelligent-applications-greenfield-bdc/drawio/sap-managed-custom-intelligent-application.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/4-modernizing-sap-bw-with-sap-bdc/drawio/bw-approach-2.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/4-modernizing-sap-bw-with-sap-bdc/drawio/bw-approach-3.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/4-modernizing-sap-bw-with-sap-bdc/drawio/bwpce-sapbdc.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/4-modernizing-sap-bw-with-sap-bdc/drawio/bw-bdc-detailed.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/4-modernizing-sap-bw-with-sap-bdc/drawio/bw-approach-1.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/4-modernizing-sap-bw-with-sap-bdc/drawio/migration-pathways.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0013/4-modernizing-sap-bw-with-sap-bdc/drawio/bw-transformations.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0025/1-sap-pi-po-to-integration-suite/drawio/sap_architecture_center_is_eic_post.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0025/1-sap-pi-po-to-integration-suite/drawio/sap_architecture_center_is_eic_pre.drawio
  ✅ OK: No external image references found

Checking: /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0022/drawio/api-managed-integration.drawio
  ✅ OK: No external image references found

============================================================================
Validation Summary:
- Total drawio files scanned: 94
- Files with external references: 2

🚨 VALIDATION FAILED: drawio files with external image references detected!

Files with external references:
===============================
  /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0008/drawio/sap_eic.drawio
  /Users/<my_user_id>/architecture-center/docs/ref-arch/RA0008/2-edge-integration-cell-on-azure/drawio/sap-edge-integration-cell-azure.drawio

External image references (image=http) are not allowed as they:
  • Create dependencies on external resources
  • May break when external resources are unavailable
  • Can cause security and privacy concerns
  • May slow down diagram loading

Please replace external image references with local images or
embedded data URIs to ensure diagrams are self-contained.

Or, we can also scan one single file:

Output:

./src/_scripts/_validate_drawio_external_refs.zsh docs/ref-arch/RA0008/drawio/sap_eic.drawio
Scanning drawio files for external image references (image=http patterns)...
============================================================================
Checking: docs/ref-arch/RA0008/drawio/sap_eic.drawio
  ❌ ERROR: External image reference found!
  📍 Found external references in these locations:
    Line: 140:        <mxCell id="GK1j6T8cdDNpq15kFjSn-72" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://cdn0.iconfinder.com/data/icons/buno-security-2/32/__virtual_private_cloud-512.png;" parent="1" vertex="1">
    Line: 160:        <mxCell id="GK1j6T8cdDNpq15kFjSn-78" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://upload.wikimedia.org/wikipedia/commons/thumb/9/93/Amazon_Web_Services_Logo.svg/1024px-Amazon_Web_Services_Logo.svg.png;" parent="1" vertex="1">
    Line: 163:        <mxCell id="GK1j6T8cdDNpq15kFjSn-80" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://logos-world.net/wp-content/uploads/2021/02/Google-Cloud-Logo.png;" parent="1" vertex="1">
    Line: 181:        <mxCell id="c7ha8ujQYmhdGz0n4e6j-57" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://seekvectors.com/files/download/Sap-01.png;" parent="2HGDGh5_L6hypmfTz_1F-5" vertex="1">
    Line: 196:        <mxCell id="2HGDGh5_L6hypmfTz_1F-11" value="" style="shape=image;verticalLabelPosition=bottom;labelBackgroundColor=default;verticalAlign=top;aspect=fixed;imageAspect=0;image=https://seekvectors.com/files/download/Sap-01.png;" parent="2HGDGh5_L6hypmfTz_1F-8" vertex="1">

============================================================================
Validation Summary:
- Total drawio files scanned: 1
- Files with external references: 1

🚨 VALIDATION FAILED: drawio files with external image references detected!

Files with external references:
===============================
  docs/ref-arch/RA0008/drawio/sap_eic.drawio

External image references (image=http) are not allowed as they:
  • Create dependencies on external resources
  • May break when external resources are unavailable
  • Can cause security and privacy concerns
  • May slow down diagram loading

Please replace external image references with local images or
embedded data URIs to ensure diagrams are self-contained.

@cernus76 cernus76 requested review from a team, jmsrpp and navyakhurana as code owners September 30, 2025 13:16
@cernus76 cernus76 added the ready for review This need to be reviewed label Sep 30, 2025
@julian-schambeck
Copy link
Contributor

@cernus76 Cool, thanks for trying it out! By the way, is dev really supposed to be the target branch of this PR?

We might want to strip the /Users/<my_user_id>/architecture-center/docs/ part from the output. It feels somewhat redundant 😃 Or we shorten the list, and only list the problematic files.

In the future, the validator could have something similar and make a suggestion to embed any images. That would be nice.

@cernus76 cernus76 changed the base branch from dev to release-v2 October 3, 2025 13:59
@cernus76
Copy link
Contributor Author

cernus76 commented Oct 3, 2025

@cernus76 Cool, thanks for trying it out! By the way, is dev really supposed to be the target branch of this PR?

We might want to strip the /Users/<my_user_id>/architecture-center/docs/ part from the output. It feels somewhat redundant 😃 Or we shorten the list, and only list the problematic files.

In the future, the validator could have something similar and make a suggestion to embed any images. That would be nice.

@julian-schambeck I have changed for release-v2 because it will replace the existing dev branch very soon.
For the rest, yes the full path is not needed but I think it will need to be reworked because we do not need all of that for the GH action. I let @navyakhurana make the necessary changes. My approach is more local/system admin to identify non compliant files. Thanks for the feedback!

@navyakhurana
Copy link
Contributor

@cernus76 Thanks for the script.
Yes, we can add it as a step in the current site build in GH actions. for that I would have to checkout the paths that you have mentioned as ideally like other scripts it would be coming from github env or github api to fetch the drawios.

@cernus76 cernus76 removed the ready for review This need to be reviewed label Oct 10, 2025
@cernus76 cernus76 marked this pull request as draft October 10, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants