Skip to content

Conversation

@mikerodonnell89
Copy link
Member

@mikerodonnell89 mikerodonnell89 commented Jun 11, 2025

downport of #13300

@mikerodonnell89 mikerodonnell89 requested a review from a team June 11, 2025 20:25
@mikerodonnell89 mikerodonnell89 self-assigned this Jun 11, 2025
@netlify
Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 1f485ab
🔍 Latest deploy log https://app.netlify.com/projects/fundamental-ngx/deploys/68da901211a6bd0008b664a6
😎 Deploy Preview https://deploy-preview-13343--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Jul 30, 2025

Visit the preview URL for this PR (updated for commit 1f485ab):

https://fundamental-ngx-gh--pr13343-fix-13067-block-scro-mqi3ful1.web.app

(expires Thu, 02 Oct 2025 14:05:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@CSEHoangV
Copy link
Contributor

CSEHoangV commented Jul 31, 2025

I just checked the fix as requested. After drag and drop, the scrollbar is not enabled back and the table is no longer scrollable:

2025-07-31_10-00-03.mp4

I think we should not disable it and may allow the action to be in some certain ways, but need to do the research on functional requirement. For example, I saw this from UI5 table which still allowed table scrollable while drag/drop.

2025-07-31_10-04-13.mp4

@droshev droshev changed the title fix(platform): disable scrolling during table row drag and drop [WIP] fix(platform): disable scrolling during table row drag and drop Jul 31, 2025
@droshev
Copy link
Contributor

droshev commented Jul 31, 2025

@mikerodonnell89 will look once he is back

@mikerodonnell89
Copy link
Member Author

I just checked the fix as requested. After drag and drop, the scrollbar is not enabled back and the table is no longer scrollable:

Just pushed a fix for this ^

I think we should not disable it and may allow the action to be in some certain ways, but need to do the research on functional requirement. For example, I saw this from UI5 table which still allowed table scrollable while drag/drop.

Apologies, we are looking to implement this in a later PR - this PR just looks to prevent scrolling during a drag

@mikerodonnell89 mikerodonnell89 changed the title [WIP] fix(platform): disable scrolling during table row drag and drop fix(platform): disable scrolling during table row drag and drop Sep 25, 2025
@droshev
Copy link
Contributor

droshev commented Sep 29, 2025

@I543348 It seems like your team doesn't need this so we will close it for now. We can always discuss it in the future if a new interest arises.

@mikerodonnell89 mikerodonnell89 merged commit d573411 into ng-15-downport Oct 2, 2025
18 of 19 checks passed
@mikerodonnell89 mikerodonnell89 deleted the fix/13067-block-scroll-during-drag-ng15 branch October 2, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants