Skip to content

Disable TransportSkipVerification in sonarExecuteScan #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −2
Open

Disable TransportSkipVerification in sonarExecuteScan #5430

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
997ca71
Update sonarExecuteScan.go
alexander-petkov-SAP Jul 29, 2025
99796fe
Merge branch 'master' into remove_TransportSkipVerification
manjunathSurendrakumar Aug 21, 2025
9ac9049
Merge branch 'master' into remove_TransportSkipVerification
manjunathSurendrakumar Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/sonarExecuteScan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@ func sonarExecuteScan(config sonarExecuteScanOptions, _ *telemetry.CustomData, i
javaToolOptions := fmt.Sprintf("-Dhttp.proxyHost=%v -Dhttp.proxyPort=%v", host, port)
os.Setenv("JAVA_TOOL_OPTIONS", javaToolOptions)

apiClient.SetOptions(piperhttp.ClientOptions{TransportProxy: transportProxy, TransportSkipVerification: true})
//apiClient.SetOptions(piperhttp.ClientOptions{TransportProxy: transportProxy, TransportSkipVerification: true})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just remove the unused code ?

log.Entry().Infof("HTTP client instructed to use %v proxy", proxy)

} else {
//TODO: implement certificate handling
apiClient.SetOptions(piperhttp.ClientOptions{TransportSkipVerification: true})
//apiClient.SetOptions(piperhttp.ClientOptions{TransportSkipVerification: true})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the else block?

}

sonar = sonarSettings{
Expand Down
Loading