Skip to content

Set default wait parameter value for CloudFoundryCreateService & CloudFoundryCreateServiceKey #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Set default wait parameter value for CloudFoundryCreateService & CloudFoundryCreateServiceKey #5458

wants to merge 5 commits into from
+10 −6

Conversation

dominiklendle
Copy link
Member

Description

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

@dominiklendle dominiklendle self-assigned this Aug 25, 2025
@dominiklendle dominiklendle requested a review from a team as a code owner August 25, 2025 09:34
@DanielMieg
Copy link
Member

I would not change the implementation - if possible. Maybe it is enough to change the defaults in https://github.com/SAP/jenkins-library/blob/master/resources/com.sap.piper/pipeline/abapEnvironmentPipelineDefaults.yml ?

@dominiklendle
Copy link
Member Author

I would not change the implementation - if possible. Maybe it is enough to change the defaults in https://github.com/SAP/jenkins-library/blob/master/resources/com.sap.piper/pipeline/abapEnvironmentPipelineDefaults.yml ?

Good point. I also tried to pursue this option. However, the steps might also be called independently outside of a pipeline with default configuration. Therefore we should ensure, that it stays compatible.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dominiklendle
Copy link
Member Author

/it-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dominiklendle dominiklendle

Labels
ABAP work in progress 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklendle @DanielMieg