Fix(preview-middleware): adjust fallback ui5 version #3722
Conversation
heimwege
added
preview-middleware
🦋 Changeset detectedLatest commit: 433ef04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if (!version) { | ||
| Log.error('Could not get UI5 version of application. Using version: 1.130.0 as fallback.'); | ||
| version = '1.130.0'; | ||
| Log.error('Could not get UI5 version of application. Using version: 1.130.9 as fallback.'); |
There was a problem hiding this comment.
Seems odd to have a hardcoded version here at all
There was a problem hiding this comment.
The fallback is being used in case requesting the version from the UI5 sources does not work. So If you know of any other option than to hard code it... I'm open for suggestions. As discussed in #3557 (comment) using ui5-info does not seem to be one.
There was a problem hiding this comment.
ui5-info does provide fallbacks but not patch version fallbacks. Why is a patch version necessary as a fallback?
There was a problem hiding this comment.
ui5-info reads the UI5 version from UI5. So it is not a suitable fallback in case UI5 does not return a UI5 version (see #3557 (comment)).
Not sure why we need to discuss about who needs a patch version, but here we go:
…middleware/fallback-ui5-version # Conflicts: # packages/preview-middleware/src/base/flp.ts
|
2 participants
spin-off from #3557 (comment)
And also no longer print the fetch error that lead to the fallback as error because its confusing. Changed this to debug.