fix(project-access): refreshSpecificationDistTags - prevent caching specification-dist-tags.json if an error is returned in the JSON from npm view @sap/ux-specification dist-tags --json
#3755
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not write specification dist tags if error is in response
🦋 Changeset detectedLatest commit: a019480 The changes in this PR will be included in the next version bump. This PR includes changesets to release 49 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
comment
Klaus-Keller
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Thanks @815are.
- Check for error before storing
dist-tag looks good - changeset exists
- test coverage is great
- did a visual review, no manual test
approved from my side.
broksy
approved these changes
Oct 22, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional improvement after -> #3754
3754 - tries to refresh
specification-dist-tags.jsonif file contains error.This PR prevents writing
specification-dist-tags.jsonif error is returned.In case if
specification-dist-tags.jsondoes not exist, then on next call logic will try to load dist tags again.