chore: extend form-validity test for ui5-checkbox and ui5-select #11823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends form-support tests for ui5-checkbox and ui5-select to verify they expose the Constraint Validation API (validity, checkValidity(), reportValidity()) and respond to the :invalid CSS pseudo-class.
- Added validity checks and
:invalidselector assertions for#cb5(checkbox) - Added validity checks and
:invalidselector assertions for#select9(select)
Comments suppressed due to low confidence (1)
packages/main/cypress/specs/FormSupport.cy.tsx:55
- [nitpick] Indentation in this added block is inconsistent with the surrounding code. Align the spacing with the project’s style guide to keep formatting uniform.
.then($el => {
kineticjs
force-pushed
the
cb-select-enhance-validity
branch
from
a75466a to
0b266f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #10487, extend the tests to check that both ui5-checkbox and ui5-select correctly expose a "validity" property and related methods required by the Constraint Validation API, as well as are selectable using the :invalid CSS pseudo class.