Skip to content

test(ui5-multi-combobox): integrate cypress tests #11853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 21, 2025
Merged

Conversation

elenastoyanovaa
Copy link
Contributor

No description provided.

Copy link
Contributor

@ndeshev ndeshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the test migration looks comprehensive and well written, I only have a couple minor comments

Copy link
Contributor

@ndeshev ndeshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are leading spaces on empty lines - #1853 #1911 #1951

@ndeshev
Copy link
Contributor

ndeshev commented Jul 16, 2025

Locally the accessibility tests are failing with this error:

 2) Accessibility
       "after each" hook for "Should apply aria-controls and aria-haspopup":
     CypressError: Cypress detected that you returned a promise from a command while also invoking one or more cy commands in that promise.

The command that returned the promise was:

  > `cy.find()`

The cy command you invoked inside the promise was:

  > `cy.log()`

Because Cypress commands are already promise-like, you don't need to wrap them or return your own promise.

Cypress will resolve your command with whatever the final Cypress command yields.      

The reason this is an error instead of a warning is because Cypress internally queues commands serially whereas Promises execute as soon as they are invoked. Attempting to reconcile this would prevent Cypress from ever resolving.

https://on.cypress.io/returning-promise-and-commands-in-another-command

Because this error occurred during a `after each` hook we are skipping all of the remaining tests.
image

@elenastoyanovaa
Copy link
Contributor Author

Locally the accessibility tests are failing with this error:

 2) Accessibility
       "after each" hook for "Should apply aria-controls and aria-haspopup":
     CypressError: Cypress detected that you returned a promise from a command while also invoking one or more cy commands in that promise.

The command that returned the promise was:

  > `cy.find()`

The cy command you invoked inside the promise was:

  > `cy.log()`

Because Cypress commands are already promise-like, you don't need to wrap them or return your own promise.

Cypress will resolve your command with whatever the final Cypress command yields.      

The reason this is an error instead of a warning is because Cypress internally queues commands serially whereas Promises execute as soon as they are invoked. Attempting to reconcile this would prevent Cypress from ever resolving.

https://on.cypress.io/returning-promise-and-commands-in-another-command

Because this error occurred during a `after each` hook we are skipping all of the remaining tests.
image

I am not able to reproduce it, maybe it was corrected after applying your comments.

@elenastoyanovaa elenastoyanovaa requested a review from ndeshev July 16, 2025 14:40
@elenastoyanovaa elenastoyanovaa merged commit 1e8fe40 into main Jul 21, 2025
26 of 29 checks passed
@elenastoyanovaa elenastoyanovaa deleted the mcb-tests branch July 21, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants