Skip to content

Conversation

@henrylay97
Copy link
Member

@henrylay97 henrylay97 commented Nov 19, 2025

There is a long term bug in the PandoraModularShower (post-pandora, not pandora itself) algorithm that relates to the “best plane” that is assigned to each shower.
The idea of the best plane field is that it indicates which plane we should use for calorimetry (energy and dE/dx).
Currently, the best plane is associated with just dE/dx and is often incorrectly assigned to plane 0 (the first induction plane).

This is a hotfix for the SBND Fall Validation II production, which allows for separate calculations for dE/dx and energy. Details of the work towards this hotfix (and the full fix that will follow can be found in these slides. A shortened version of these slides will be presented in Friday's First Analyses meeting.

An accompanying PR exists to fill this information: SBNSoftware/sbncode#608

  • Have you run git fetch and pulled the latest changes from the branch you're basing your PR against?
  • If you're adding new classes, have you added them to classes_def.xml in the relevant directory?
  • If you're updating classes, have you incremented the ClassVersion in classes_def.xml?

@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production Nov 19, 2025
@kjplows kjplows moved this to Partially reviewed in SBN software development Nov 19, 2025
@linyan-w linyan-w moved this from Waiting on Reviewer to Expected for validation II MC in SBND 2025 Fall Production Nov 19, 2025
@nathanielerowe nathanielerowe moved this from Expected for validation II MC to Reviewer Approved in SBND 2025 Fall Production Nov 20, 2025
@kjplows kjplows moved this from Partially reviewed to Testing in SBN software development Nov 20, 2025
@kjplows
Copy link
Contributor

kjplows commented Nov 20, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@kjplows kjplows moved this from Reviewer Approved to Ready for CI in SBND 2025 Fall Production Nov 20, 2025
@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to Urgent checks in SBN software development Nov 20, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Ready for CI to RM Approved in SBND 2025 Fall Production Nov 20, 2025
@kjplows kjplows moved this from Urgent checks to To merge in SBN software development Nov 20, 2025
@kjplows kjplows merged commit 80c2091 into develop Nov 21, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 21, 2025
@nathanielerowe nathanielerowe moved this from RM Approved to In tagged release in SBND 2025 Fall Production Nov 22, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

7 participants