-
Notifications
You must be signed in to change notification settings - Fork 35
Implementing SimEnergyDeposit filter for ICARUS variation studies in release tag version v09_89_01_01 #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Version v09_89_01_01, patch release for v09_89_01
Fixed bug where out of bounds IDs set TPC and Plane info to bad values.
Update NearestWireID
last valid point for last segment validity
Merge branch 'release/v09_90_00'
weekly release of sbncode
…eToCAF_v09_83_01 Saving GENIE tree to caf [develop]
…or the NuMI reprocessing release, but put here in the version for develop.
…pe and trigger type
…com:SBNSoftware/sbncode into feature/aheggest_reassignCRTPMTMatchIDinCAF
Accommodate breaking changes for geometry refactoring
Merge branch 'release/v10_01_03'
Weekly release of sbncode based on larsoft v10_01_03
|
@jzettle thanks for creating both this and the PR against develop. Once these changes are approved, I can release a patch to v09_89_01_01 and include these changes in the next release based on the develop branch. |
…PMTMatchIDinCAF reassign CRT-PMT MatchID while filling CAFs
|
There were comments from @PetrilloAtWork on PR #486 which identically apply here. I am almost done addressing those and can update once that is completed |
|
Okay the merging of develop into this branch has caused a lot of problems in updating this based on the comments I received. I will need to understand what I can do to recover and push the changes I need to |
…tware/sbncode into feature/jzettle_sedfilter
|
I resolved it and was able to push the updates based on @PetrilloAtWork but now I'm concerned about getting this into a patch of v09_89_01_01 based on new things that are now in this branch. I hope my concern is unfounded. |
|
Closing this as it got complicated. Will wait until we have the new release branch in place before requesting another PR against it |
Description
Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.
This pull request introduces a larsoft module that can be run during the detsim stage to filter out SimEnergyDeposits around a rectangular volume and creates a new SimEnergyDeposit collection (with a different name,
sedfilter) that can be passed to the downstream WireCell processing. The goal of this is to allow for a systematic variation sample that addresses the fact that the induction 1 wire gap at z = 0 is not simulated in the icarus geometry. This PR does not change anything with the standard ICARUS or SBND simulation and the module is completely optional to include.This PR addresses the module and a companion PR in icaruscode (SBNSoftware/icaruscode#778) addresses the fcl configuration and WireCell configuration options of running it as a variation sample.