Skip to content

Conversation

@jzettle
Copy link
Contributor

@jzettle jzettle commented Dec 2, 2024

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.
This pull request introduces a larsoft module that can be run during the detsim stage to filter out SimEnergyDeposits around a rectangular volume and creates a new SimEnergyDeposit collection (with a different name, sedfilter) that can be passed to the downstream WireCell processing. The goal of this is to allow for a systematic variation sample that addresses the fact that the induction 1 wire gap at z = 0 is not simulated in the icarus geometry. This PR does not change anything with the standard ICARUS or SBND simulation and the module is completely optional to include.

This PR addresses the module and a companion PR in icaruscode (SBNSoftware/icaruscode#778) addresses the fcl configuration and WireCell configuration options of running it as a variation sample.

  • Have you added a label? (bug/enhancement/physics etc.)
  • yes
  • Have you assigned at least 1 reviewer?
  • yes
  • Is this PR related to an open issue / project?
  • yes, for ICARUS systematics studies for the first oscillation analysis, Gap in tracks at boundary of induction 1 plane icaruscode#769
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • no
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • yes, there is a companion PR for icaruscode that includes fcl files and wirecell configuration options in order to run this as a systematic variation (Feature/jzettle sedfilter icaruscode#778)
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.
  • no, this is largely my own work with discussions with @jzennamo

jedori0228 and others added 30 commits April 26, 2024 13:13
Version v09_89_01_01, patch release for v09_89_01
Fixed bug where out of bounds IDs set TPC and Plane info to bad values.
last valid point for last segment validity
Merge branch 'release/v09_90_00'
weekly release of sbncode
…eToCAF_v09_83_01

Saving GENIE tree to caf [develop]
…or the NuMI reprocessing release, but put here in the version for develop.
@jzettle jzettle added the enhancement New feature or request label Dec 2, 2024
@ibsafa
Copy link
Contributor

ibsafa commented Dec 2, 2024

@jzettle thanks for creating both this and the PR against develop. Once these changes are approved, I can release a patch to v09_89_01_01 and include these changes in the next release based on the develop branch.

@jzettle
Copy link
Contributor Author

jzettle commented Dec 4, 2024

There were comments from @PetrilloAtWork on PR #486 which identically apply here. I am almost done addressing those and can update once that is completed

@jzettle
Copy link
Contributor Author

jzettle commented Dec 6, 2024

Okay the merging of develop into this branch has caused a lot of problems in updating this based on the comments I received. I will need to understand what I can do to recover and push the changes I need to

@jzettle
Copy link
Contributor Author

jzettle commented Dec 6, 2024

I resolved it and was able to push the updates based on @PetrilloAtWork but now I'm concerned about getting this into a patch of v09_89_01_01 based on new things that are now in this branch. I hope my concern is unfounded.

@jzettle jzettle closed this Dec 6, 2024
@jzettle
Copy link
Contributor Author

jzettle commented Dec 6, 2024

Closing this as it got complicated. Will wait until we have the new release branch in place before requesting another PR against it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.