Skip to content

CRTPMTMatching fix: remove unused counters #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibsafa merged 3 commits into from
Jan 23, 2025
Merged

CRTPMTMatching fix: remove unused counters #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4742e00
replace uint with unsigned int in FillCRTPMTMatch
aheggest Dec 3, 2024
08169af
remove unused counters from FillCRTPMTMatch function
aheggest Dec 3, 2024
67c896f
Merge branch 'develop' into feature/aheggest_eassignCRTPMTMatchIDinCA…
ibsafa Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions sbncode/CAFMaker/CAFMaker_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,12 +1559,8 @@ void CAFMaker::produce(art::Event& evt) noexcept {
if(crtpmtmatch_handle.isValid()){
const std::vector<sbn::crt::CRTPMTMatching> &crtpmtmatches = *crtpmtmatch_handle;
for (unsigned i = 0; i < crtpmtmatches.size(); i++) {
int topen = 0, topex = 0, sideen = 0, sideex = 0; // bottomen = 0, bottomex = 0;
srcrtpmtmatches.emplace_back();
FillCRTPMTMatch(crtpmtmatches[i],
topen, topex, sideen, sideex,
//bottomen, bottomex,
srcrtpmtmatches.back());
FillCRTPMTMatch(crtpmtmatches[i], srcrtpmtmatches.back());
}
}

Expand Down
3 changes: 1 addition & 2 deletions sbncode/CAFMaker/FillReco.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,6 @@ namespace caf
}

void FillCRTPMTMatch(const sbn::crt::CRTPMTMatching &match,
int &topen, int &topex, int &sideen, int &sideex,
//int &bottomen, int &bottomex,
caf::SRCRTPMTMatch &srmatch,
bool allowEmpty){
// allowEmpty does not (yet) matter here
Expand All @@ -159,6 +157,7 @@ namespace caf
srmatch.flashPosition = SRVector3D (match.flashPosition.X(), match.flashPosition.Y(), match.flashPosition.Z());
srmatch.flashYWidth = match.flashYWidth;
srmatch.flashZWidth = match.flashZWidth;
unsigned int topen = 0, topex = 0, sideen = 0, sideex = 0;
for(const auto& matchedCRTHit : match.matchedCRTHits){
caf::SRMatchedCRT matchedCRT;
matchedCRT.PMTTimeDiff = matchedCRTHit.PMTTimeDiff;
Expand Down
2 changes: 0 additions & 2 deletions sbncode/CAFMaker/FillReco.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,6 @@ namespace caf
caf::SROpFlash &srflash,
bool allowEmpty = false);
void FillCRTPMTMatch(const sbn::crt::CRTPMTMatching &match,
int &topen, int &topex, int &sideen, int &sidex,
//int &bottomen, int &bottomex,
caf::SRCRTPMTMatch &srmatch,
bool allowEmpty = false);

Expand Down