Skip to content

Conversation

@SFBayLaser
Copy link
Contributor

Description

This PR introduces code to make use of the ChannelROI objects in sbnobj. ChannelROI objects are identically recob::Wire objects except the ADC values are stored as short ints, not floats, which enables at least a factor of 2 savings in output space. In order to convert between floats and short ints while preserving as much resolution as possible, we do a "dynamic scaling" where the peak values of the full waveform are used to determine a scale factor so we gain decimal points before converting to short int.
At the sbncode level we have the following main additions:

  1. a module "WireToChannelROI" which converts recob::Wire data to ChannelROI output,
  2. a module "ChannelROIToWire" which goes the other way
  3. a version of the hit finder, called "GaussHitFinderSBN_module" which is identically the hit finder in larreco BUT operating on ChannelROIs instead of recob:Wires. This module outputs recob::Hits and has been confirmed to work properly with downstream users of hits.
    There are also updates to fcl definition files, etc., to make it all work.

NOTE that this PR depends on PR #129 in sbnobj

  • [yes] Have you added a label? (bug/enhancement/physics etc.)
  • [yes] Have you assigned at least 1 reviewer?
  • [yes] Is this PR related to an open issue / project?
  • [no] Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • [yes] Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • [no] Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@kjplows
Copy link
Contributor

kjplows commented Apr 23, 2025

trigger build SBNSoftware/sbnanaobj#129

@kjplows
Copy link
Contributor

kjplows commented Apr 25, 2025

trigger build SBNSoftware/sbnobj#129

@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Apr 25, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to Urgent checks in SBN software development Apr 25, 2025
@kjplows
Copy link
Contributor

kjplows commented Apr 25, 2025

trigger build SBNSoftware/sbnobj#129

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Urgent checks to To merge in SBN software development Apr 25, 2025
@kjplows kjplows merged commit 2d68c12 into develop Apr 28, 2025
4 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Apr 28, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Apr 28, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done
Status: Todo

Development

Successfully merging this pull request may close these issues.

6 participants