Feature/maxd bnb qual cut

[maxdubnowski]

Description

Added additional information to the BNBSpillInfo module including additional monitors and monitor offsets from IFBeam that allow for the creation of the BNB FOM adapted from MicroBooNE using sbnd information. My DocDB presentation: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=42480
I am not sure who is a CAF maintainer...

Requires linking sbnobj and sbnanaobj. Their PRs are listed below:
sbnobj: PR135 SBNSoftware/sbnobj#135
sbnanaobj: PR146 SBNSoftware/sbnanaobj#146

[lyates17]

Added Gianluca to the list of reviewers, as a CAF expert

[PetrilloAtWork]

The code here is tough, in many places obscure with references lost in time.
I have left comments throughout it, with the general intention that:

• code be documented in Doxygen format
• at least the parts that are more under our control (e.g. quality selections and cut) be documented and shaped in a maintainable way
• code be adjusted to be more readable and maintainable
• a likely memory leak (involving, unsurprisingly, ROOT) be addressed.

Thank you for taking this hard task on your shoulders!

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[kjplows]

@maxdubnowski , I am seeing failures in getFOM.cpp - looks like a typo?

[354/1876] Building CXX object sbncode/sbncode/BeamSpillInfoRetriever/CMakeFiles/sbn_getFOM.dir/getFOM.cpp.o
FAILED: sbncode/sbncode/BeamSpillInfoRetriever/CMakeFiles/sbn_getFOM.dir/getFOM.cpp.o 
/cvmfs/larsoft.opensciencegrid.org/products/gcc/v12_1_0/Linux64bit+3.10-2.17/bin/g++ -DNDEBUG -Dsbn_getFOM_EXPORTS -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbnobj -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbnobj -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbnanaobj -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbnanaobj -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbnalg -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbnalg -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndaq_artdaq_core -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndaq_artdaq_core -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbncode -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndutil -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndutil -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode -I/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndcode -I/cvmfs/larsoft.opensciencegrid.org/products/clhep/v2_4_7_1/Linux64bit+3.10-2.17-e26-prof/include -isystem /cvmfs/larsoft.opensciencegrid.org/products/root/v6_28_12/Linux64bit+3.10-2.17-e26-p3915-prof/include -isystem /cvmfs/larsoft.opensciencegrid.org/products/cetlib_except/v1_09_01/include -g -O3 -fno-omit-frame-pointer -DNDEBUG -std=c++17 -fPIC -Werror -Wno-error=deprecated-declarations -frecord-gcc-switches -grecord-gcc-switches -Wall -Werror=return-type -pedantic -Wno-unused-local-typedefs -MD -MT sbncode/sbncode/BeamSpillInfoRetriever/CMakeFiles/sbn_getFOM.dir/getFOM.cpp.o -MF sbncode/sbncode/BeamSpillInfoRetriever/CMakeFiles/sbn_getFOM.dir/getFOM.cpp.o.d -o sbncode/sbncode/BeamSpillInfoRetriever/CMakeFiles/sbn_getFOM.dir/getFOM.cpp.o -c /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/BeamSpillInfoRetriever/getFOM.cpp
/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/BeamSpillInfoRetriever/getFOM.cpp:8:10: fatal error: TH1D.H: No such file or directory
    8 | #include "TH1D.H"
      |          ^~~~~~~~
compilation terminated.

If you could take a look at this when you can, it would be much appreciated. Thanks!

[kjplows]

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode@v10_09_00 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj#135 SBNSoftware/sbnanaobj#146 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_34_00

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[kjplows]

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbnobj#135 SBNSoftware/sbnanaobj#146

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

[jacoblarkin]

Looks good from my side and doesn't seem to affect anything ICARUS related. At some point we should test this implementation of the FOM with ICARUS as well, but that's not necessary to approve this.