Calib NTuple CRT Timing Additions #557

henrylay97 · 2025-08-21T09:28:08Z

Description

Part of a pair of PRs to enhance the SBND CRT contribution to the calibration ntuples. (See also SBNSoftware/sbnobj#139).

This PR:

Adds a new T0 source (SBND-only) from CRTSpacePoint matching. This falls in lowest priority (after Pandora (Both), CRTTrack (SBND-only) and CRTHit (ICARUS-only) and will be denoted by whicht0==3.
Applies appropriate x shifts to TPC track end points for this new T0.
Adds in x shifting of hit / spacepoint using either of the SBND-only CRT T0 tags - previously only implemented for CRTHit.
Skips shower-like PFPs now that all PFPs are characterised as tracks, this returns to original behaviour (before ~2years ago) and removes a sea of deltas and michels from the calib ntuples.

Presenting today at the calibration meeting - will link slides after.

Have you added a label? (bug/enhancement/physics etc.)
Have you assigned at least 1 reviewer?
Is this PR related to an open issue / project?
Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

…& shift for all CRT matchings

This reverts commit 5acaf5e.

linyan-w

Thanks a lot Henry!

DocDB entry: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=43000

Now we have whicht0 = 0 for TPC, 1 for SBND CRT track, 3 for SBND CRT spacepoint, 2 for ICARUS CRT hit. It's not intuitive but reasonably documented in code and the docdb entry, so looks good to me! Thanks!

…_ntuples_crt_t0

kjplows · 2025-09-02T22:39:57Z

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbnobj#139

FNALbuild · 2025-09-02T23:11:16Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-09-02T23:22:53Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-09-02T23:30:39Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-02T23:38:10Z

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-02T23:42:52Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-02T23:44:50Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

kjplows · 2025-09-03T00:03:52Z

@mrmooney @gputnam @francescopoppi just pinging here - from a CI perspective this and #564 (production branch version, on the larsoft v10_06 line) are good to go. Any chance you could look at this? Thanks!

sbncode/Calibration/TrackCaloSkimmer_module.cc

gputnam · 2025-09-10T22:16:57Z

sbncode/Calibration/TrackCaloSkimmer_module.cc

+      double anodeDistance = (hit.PeakTime()-dclock.Time2Tick(dclock.TriggerTime())-time/dclock.TPCClock().TickPeriod())*dclock.TPCClock().TickPeriod()*driftv;
+      double wirePlaneX = wireReadout->Plane(geo::PlaneID(hit.WireID().Cryostat, hit.WireID().TPC, hit.WireID().Plane)).GetCenter().X();
+
+      recoX = wirePlaneX - driftDir*anodeDistance;


Since xshift is now being passed as a parameter, shouldn't you just apply it instead of calculating recoX here?

Backing up -- tp.x and sp.x should be shifted by the same amount. They shouldn't have different calculations.

Yeah. This second calculation comes from a PR from yourself and Francesco back in March? I was just broadening it to use any CRT T0 rather than just the ICARUS hit tag.

I am happy to pass the xShift, validate the same result is arrived at, and assuming so remove the second calc.

Yes, please do use the xShift

@gputnam @francescopoppi I am seeing ~0mm, ~3mm and ~6mm differences between this technique and pure use of the xshift. Clearly one of the methods doesn't / double accounts for interplane drift time.

I will try and investigate this this afternoon but given you implemented it I would welcome your input - do you know for example, whether this is over corrected?

So, you do want the interplane timing corrected for in the x-shift. The most important thing though is that the tp and the sp are shifted in x by the same amount.

But clearly one of these instances is wrong so it's worth understanding which.

I would expect that the interplane drift is already accounted for in the creation of the spacepoints given they're already 3D constructs. I'm not familiar with the trajectory points so I would need to understand how they work.

I have looked into this more - SPs explicitly account for the interplane drift as would be expected, TPs are based on the trajectory which itself is a fit to the SPs.

Correcting for interplane drift here is wrong. I've made a couple of plots that show that the SP x's give and agreed x range (with the first induction location being the limit) whilst the TP x's with their current correction give shifted distributions.

I am therefore going to remove this section and correct all locations by the xshift calculated previously, avoiding double correcting.

Commit now pushed.

@mrmooney @linyan-w just making you aware of this too!

Thanks Henry for fixing this!

kjplows · 2025-09-18T13:52:02Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbnobj#139

FNALbuild · 2025-09-18T14:11:12Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-09-18T14:22:49Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-09-18T14:34:19Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-18T14:38:13Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-18T14:39:30Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-09-18T14:40:10Z

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

henrylay97 added 10 commits July 31, 2025 05:24

Add CRTSpacePoint tagging (SBND) to calib ntuples and document score …

be58342

…& shift for all CRT matchings

Add xshifts for hits and spacepoints

817cac5

Move definition of hasT0

e8e6c98

Skip shower-type PFPs

e639d1a

Replace throughgoing selection and add exiting selection as previous

01bac92

Add event displays for questionable cases

5acaf5e

Revert "Add event displays for questionable cases"

4b529c4

This reverts commit 5acaf5e.

Return to original selection setup

6e6a17e

Remove extra tool for PR

48b3474

Sort indentation

9313298

henrylay97 requested review from francescopoppi, gputnam, linyan-w and mrmooney August 21, 2025 09:28

henrylay97 self-assigned this Aug 21, 2025

henrylay97 added this to SBND 2025 Fall Production Aug 21, 2025

henrylay97 added the enhancement New feature or request label Aug 21, 2025

henrylay97 mentioned this pull request Aug 21, 2025

Calib NTuple CRT Timing Additions SBNSoftware/sbnobj#139

Merged

henrylay97 moved this to Todo in SBND 2025 Fall Production Aug 21, 2025

henrylay97 linked an issue Aug 21, 2025 that may be closed by this pull request

CRT-TPC Matching in Calib NTuples #549

Closed

linyan-w approved these changes Aug 21, 2025

View reviewed changes

kjplows added this to SBN software development Aug 26, 2025

kjplows moved this to Open pull requests in SBN software development Aug 26, 2025

kjplows moved this from Open pull requests to Partially reviewed in SBN software development Aug 26, 2025

Merge remote-tracking branch 'origin/develop' into feature/hlay_calib…

551bccd

…_ntuples_crt_t0

henrylay97 mentioned this pull request Sep 1, 2025

Calib NTuple CRT Timing Additions - Production 2025A Version #564

Merged

linyan-w moved this from Todo to Approved in SBND 2025 Fall Production Sep 2, 2025

kjplows moved this from Partially reviewed to Testing in SBN software development Sep 2, 2025

kjplows moved this from Testing to Urgent checks in SBN software development Sep 3, 2025

linyan-w moved this from Approved to To be merged in SBND 2025 Fall Production Sep 10, 2025

gputnam reviewed Sep 10, 2025

View reviewed changes

linyan-w moved this from To be merged to Approved in SBND 2025 Fall Production Sep 11, 2025

kjplows moved this from Urgent checks to Partially reviewed in SBN software development Sep 12, 2025

henrylay97 added 2 commits September 16, 2025 06:59

Make shower exclusion fcl-toggled but defaulted on

56fd8be

Use passed xshift

5e6c3dc

mrmooney approved these changes Sep 18, 2025

View reviewed changes

gputnam approved these changes Sep 18, 2025

View reviewed changes

kjplows moved this from Partially reviewed to To merge in SBN software development Sep 18, 2025

Merge branch 'develop' into feature/hlay_calib_ntuples_crt_t0

6896344

kjplows merged commit d8b2f20 into develop Sep 18, 2025

github-project-automation bot moved this from To merge to Done in SBN software development Sep 18, 2025

kjplows moved this from Done to Recently done in SBN software development Sep 18, 2025

linyan-w moved this from Reviewer Approved to In tagged release in SBND 2025 Fall Production Sep 18, 2025

kjplows moved this from Recently done to Done in SBN software development Oct 1, 2025

Calib NTuple CRT Timing Additions #557

Calib NTuple CRT Timing Additions #557

Uh oh!

Conversation

henrylay97 commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

linyan-w left a comment

Choose a reason for hiding this comment

Uh oh!

kjplows commented Sep 2, 2025

Uh oh!

FNALbuild commented Sep 2, 2025

Uh oh!

FNALbuild commented Sep 2, 2025

Uh oh!

FNALbuild commented Sep 2, 2025

Uh oh!

FNALbuild commented Sep 2, 2025

Uh oh!

FNALbuild commented Sep 2, 2025

Uh oh!

FNALbuild commented Sep 2, 2025

Uh oh!

kjplows commented Sep 3, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjplows commented Sep 18, 2025

Uh oh!

FNALbuild commented Sep 18, 2025

Uh oh!

FNALbuild commented Sep 18, 2025

Uh oh!

FNALbuild commented Sep 18, 2025

Uh oh!

FNALbuild commented Sep 18, 2025

Uh oh!

FNALbuild commented Sep 18, 2025

Uh oh!

FNALbuild commented Sep 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

henrylay97 commented Aug 21, 2025 •

edited

Loading