Skip to content

Conversation

@npallat
Copy link
Contributor

@npallat npallat commented Sep 23, 2025

Description

This includes updates to FillTrigger.cxx to take trigger data products from detsim to be able to put them in the cafs: the variables include a bool of passed/failed trigger, number of PMT pairs over threshold, and two variables for the purpose of validation giving us the trigger response in a flattened vector and the size of the pulses (so the vector can be un-flattened).

This pull request must be merged after the detsim updates and with the other updates for the CAF files: sbnanaobj and sbnobj.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@kjplows kjplows moved this to Partially reviewed in SBN software development Sep 24, 2025
@npallat npallat requested a review from gputnam October 1, 2025 15:37
@nathanielerowe nathanielerowe removed the request for review from PetrilloAtWork October 1, 2025 16:02
@kjplows kjplows requested a review from rtriozzi October 2, 2025 13:20
@kjplows
Copy link
Contributor

kjplows commented Oct 2, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbnobj#146 SBNSoftware/sbnanaobj#161 SBNSoftware/sbndcode#830

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Copy link
Contributor

@rtriozzi rtriozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from another pair of ICARUS eyes, thanks!

@kjplows kjplows moved this from Partially reviewed to To merge in SBN software development Oct 2, 2025
@kjplows kjplows merged commit 6fa3f62 into develop Oct 2, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Oct 2, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Oct 2, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request trigger

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants