Skip to content

Conversation

@sungbinoh
Copy link
Contributor

@sungbinoh sungbinoh commented Oct 17, 2025

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

…ct commit 26e2abb92fe757510ca0a7e54444e8018aa721f7 in supera
@sungbinoh sungbinoh requested a review from jzennamo October 17, 2025 17:16
@sungbinoh sungbinoh self-assigned this Oct 17, 2025
@sungbinoh sungbinoh added the bugfix Addresses one or more bugs label Oct 17, 2025
@sungbinoh sungbinoh changed the title Feature/sungbino debug same start end v10 06 00 05 Bug fix for the exactly the same start and end positions for particles from neutrino interactions in AV Oct 17, 2025
@sungbinoh sungbinoh changed the title Bug fix for the exactly the same start and end positions for particles from neutrino interactions in AV Bug fix for the exactly the same start and end positions for particles from neutrino interactions in AV - To release/SBN2025A Oct 17, 2025
@justinjmueller
Copy link

Adding here for documentation purposes: the Supera commit in this PR removes the XA products from the LArCV files. This was done for the Fall Production due to sim. concerns. I do not expect we will be using the Spring Production branch to produce LArCV files at this point, and I also do not expect we will be using XA products on this timescale.

@sungbinoh
Copy link
Contributor Author

Adding here for documentation purposes: the Supera commit in this PR removes the XA products from the LArCV files. This was done for the Fall Production due to sim. concerns. I do not expect we will be using the Spring Production branch to produce LArCV files at this point, and I also do not expect we will be using XA products on this timescale.

Thank you for the clarification @justinjmueller !
I have reverted Supera's commit to the previous one since it is outside of this PR's scope.
Thank you for spotting the point @jzennamo ! This PR is now have update only for fixing the bug.

@kjplows kjplows moved this to Open pull requests in SBN software development Nov 4, 2025
@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_06_00_03 SBNSoftware/sbndcode@v10_06_00_05 SBNSoftware/sbn*@release/SBN2025A LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Nov 10, 2025
@kjplows kjplows moved this from Testing to To merge in SBN software development Nov 10, 2025
@kjplows kjplows merged commit b1b62d5 into release/SBN2025A Nov 12, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Nov 12, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 12, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Addresses one or more bugs

Projects

Status: Done
Status: No status

Development

Successfully merging this pull request may close these issues.

True particles from neutrino interactions often have exactly the same start and end positions

7 participants