-
Notifications
You must be signed in to change notification settings - Fork 54
Frame Shift Module to Correct Timing in Data - PR For Develop #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ftware/sbndcode into lnguyen/frame_shift_pr_dev
|
PR is identical to prod patch so a reviewer won't be pinged unless you feel it is needed @VCLanNguyen |
|
trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode@v10_09_00 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj@v10_01_02 SBNSoftware/sbnanaobj@v10_00_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_35_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode#562 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj#142 SBNSoftware/sbnanaobj#154 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_35_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
@VCLanNguyen Some changes appeard in the offbeam CAFs when running CI. Are these values meaningful in anyway? If not can we set them to reasonable default values? |
|
I added to the issue with filling SRTrigger product for SBND: https://github.com/SBNSoftware/sbncode/blob/508e45f04b9d4262a2bfd6f26b128e2b763f4b5c/sbncode/CAFMaker/FillTrigger.cxx#L37 I will circle back to this sometime in the future. |
Description
New module for timing reconstruction. Module make data products for downstream reconstruction.
Add to reco2 workflow
Description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
sbnobj dev: SBNSoftware/sbnobj#142
sbnanaobj dev: SBNSoftware/sbnanaobj#154
sbndcode dev: #804
sbncode dev: SBNSoftware/sbncode#562
Link(s) to docdb describing changes (optional)
https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090