Skip to content
Open
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
3abd95c
adjustments to new paths
Nov 6, 2025
4d2df24
Trying to get compile to solve
Nov 6, 2025
619cc9d
Assorted changes to things I don't actually use so the compiler would…
Nov 10, 2025
8c71d0b
updated sbnobj
Nov 10, 2025
bb7fca3
Forgot to take out cmake lists
Nov 13, 2025
04973a2
CMAKEList updates
Nov 13, 2025
a8816a2
Updating includes
Nov 13, 2025
7a1e130
Tried to separate the removal of classes.h but it doesn't actually work
Nov 13, 2025
70ee378
compiler is so fussy
Nov 14, 2025
9a41019
compile changes
Nov 14, 2025
8ab2400
merge issues
Nov 14, 2025
b2c99ca
updated caf maker fcl
Nov 14, 2025
2736872
fcl changes to include blips
Nov 14, 2025
dbcec4b
MC caf updates
Nov 14, 2025
f63553b
Fixing changes I didn't intend to make
Nov 19, 2025
064df71
Merge branch 'develop' into feature/AddingBlipToCAF
Nov 19, 2025
1fbb828
Fixed indentation
Jjm321814 Nov 20, 2025
90533bc
Merge branch 'feature/BlipBugFix' into feature/AddingBlipToCAF
Nov 26, 2025
382de1d
fixed library name
Jjm321814 Nov 29, 2025
1808514
TVector3 Replacement updates
Jjm321814 Nov 29, 2025
d137623
more TVector 3 conversion
Jjm321814 Nov 29, 2025
184ba70
Update Power calls
Jjm321814 Nov 29, 2025
ae53aa5
Not sure this should function
Jjm321814 Nov 29, 2025
785cf59
One more cmake update
Jjm321814 Nov 29, 2025
a23b8fe
How did I miss so many
Jjm321814 Nov 29, 2025
311ee02
How did I miss so many
Jjm321814 Nov 29, 2025
a36a2b5
Weird these cmake issues appeared now and not earlier
Jjm321814 Nov 29, 2025
e7951b5
Adding includes that are probably unneeded
Jjm321814 Nov 29, 2025
1db5fd5
Oh I just updated one spot
Jjm321814 Nov 29, 2025
813ff32
Oh I just updated one spot
Jjm321814 Nov 29, 2025
d075348
I hope I don't just replace all these tvector 3
Jjm321814 Nov 29, 2025
3a30ea5
addressing Henry comments
Jjm321814 Dec 10, 2025
4b0b4c5
Merge branch 'feature/BlipBugFix' into feature/AddingBlipToCAF
Jjm321814 Dec 10, 2025
298f171
Tab align issue
Jjm321814 Dec 10, 2025
9c94f32
Tab align issue
Jjm321814 Dec 10, 2025
c67ed63
Removed some tvector3 dependencies
Jjm321814 Jan 5, 2026
774ebe2
Merge branch 'develop' into feature/AddingBlipToCAF
Jjm321814 Jan 5, 2026
eae9be3
typo in include
Jjm321814 Jan 5, 2026
be7a13b
made pinfo position have a capital like all other blip positions
Jjm321814 Jan 5, 2026
c41582b
thanks compiler
Jjm321814 Jan 5, 2026
5d1cc28
swap one more tvector3 for geo::point_t
Jjm321814 Jan 5, 2026
39745f4
trying a different accumulator
Jjm321814 Jan 5, 2026
c44a0cf
gave up on iterator
Jjm321814 Jan 5, 2026
87ca9dc
put it back
Jjm321814 Jan 5, 2026
e627109
Removed iterator again
Jjm321814 Jan 5, 2026
c78d55d
missed a line
Jjm321814 Jan 5, 2026
10e4916
Don't know how to initilize correctly
Jjm321814 Jan 5, 2026
1b10ce5
these accumulator are not being nice
Jjm321814 Jan 5, 2026
612a577
throw out accumulator
Jjm321814 Jan 5, 2026
d49df9d
fix typo
Jjm321814 Jan 5, 2026
33bb8a3
Trying to fix runtime error
Jjm321814 Jan 5, 2026
a4b6724
Trying to fix runtime error
Jjm321814 Jan 5, 2026
a705deb
Trying to fix runtime error
Jjm321814 Jan 5, 2026
32a391c
Trying to fix runtime error
Jjm321814 Jan 5, 2026
48ef455
Revert "Trying to fix runtime error"
Jjm321814 Jan 5, 2026
2f7a877
:q
Jjm321814 Jan 5, 2026
b5e00dc
Revert "Trying to fix runtime error"
Jjm321814 Jan 5, 2026
4dfcb26
Revert "Trying to fix runtime error"
Jjm321814 Jan 5, 2026
bb4f59a
Revert "fix typo"
Jjm321814 Jan 5, 2026
378d685
Revert "throw out accumulator"
Jjm321814 Jan 5, 2026
bc843e7
Revert "these accumulator are not being nice"
Jjm321814 Jan 5, 2026
104e1ac
Revert "Don't know how to initilize correctly"
Jjm321814 Jan 5, 2026
5ce9ad2
Revert "missed a line"
Jjm321814 Jan 5, 2026
4502f76
Revert "Removed iterator again"
Jjm321814 Jan 5, 2026
6267b1e
Revert "put it back"
Jjm321814 Jan 5, 2026
50dba79
Revert "gave up on iterator"
Jjm321814 Jan 5, 2026
296d8d1
Revert "trying a different accumulator"
Jjm321814 Jan 5, 2026
4a69c2b
Revert "swap one more tvector3 for geo::point_t"
Jjm321814 Jan 5, 2026
1d49586
Revert "thanks compiler"
Jjm321814 Jan 5, 2026
361f09e
Revert "made pinfo position have a capital like all other blip positi…
Jjm321814 Jan 5, 2026
dc54a8e
Revert "typo in include"
Jjm321814 Jan 5, 2026
92d3f00
Revert "Merge branch 'develop' into feature/AddingBlipToCAF"
Jjm321814 Jan 5, 2026
b93b540
Revert "Removed some tvector3 dependencies"
Jjm321814 Jan 5, 2026
37b4ba2
Revert "Revert "Merge branch 'develop' into feature/AddingBlipToCAF""
Jjm321814 Jan 5, 2026
318787a
fixing caps again
Jjm321814 Jan 5, 2026
62286d3
still fixing runtime error
Jjm321814 Jan 5, 2026
25cd547
still fixing runtime error
Jjm321814 Jan 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

cmake_minimum_required(VERSION 3.20 FATAL_ERROR)

set(${PROJECT_NAME}_CMAKE_PROJECT_VERSION_STRING 10.11.01.01)
set(${PROJECT_NAME}_CMAKE_PROJECT_VERSION_STRING 10.12.02)
find_package(cetmodules REQUIRED)
project(sbndcode LANGUAGES CXX)

Expand Down
3 changes: 2 additions & 1 deletion sbndcode/BlipRecoSBND/Alg/BlipRecoAlg.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#include "larcorealg/Geometry/GeometryCore.h"
#include "larreco/Calorimetry/CalorimetryAlg.h"
#include "art/Framework/Principal/Event.h"

#include "larcore/Geometry/WireReadout.h"

// Microboone includes
//#include "ubevt/Database/TPCEnergyCalib/TPCEnergyCalibService.h"
Expand All @@ -53,6 +53,7 @@

// Blip-specific utils
#include "sbndcode/BlipRecoSBND/Utils/BlipUtils.h"
#include "sbnobj/SBND/Blip/BlipDataTypes.h"

// ROOT stuff
#include "TH1D.h"
Expand Down
4 changes: 3 additions & 1 deletion sbndcode/BlipRecoSBND/Alg/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ art_make_library(LIBRARY_NAME sbndcode_BlipRecoAlg
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::Calorimetry
larpandora::LArPandoraInterface
nusimdata::SimulationBase
cetlib::cetlib
Expand All @@ -34,7 +35,8 @@ art_make_library(LIBRARY_NAME sbndcode_BlipRecoAlg
sbndcode_CRTUtils
sbnobj::Common_CRT
#sbndcode_CosmicIdUtils
sbndcode_BlipUtils
sbndcode_BlipUtils
sbndobj_BlipDataTypes
)

install_headers()
Expand Down
3 changes: 2 additions & 1 deletion sbndcode/BlipRecoSBND/BlipAna_module.cc
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ const int kMaxTrks = 1000;
const int kMaxBlips = 5000;
const int kMaxG4 = 30000;
const int kMaxEDeps = 10000;
const int kMaxTrkPts = 2000;
const int kMaxTrkPts = 2000;
const int kNplanes = blip::kNplanes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we align equals and values inkeeping with previous lines.


class BlipAna;

Expand Down
4 changes: 2 additions & 2 deletions sbndcode/BlipRecoSBND/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ set( MODULE_LIBRARIES larcorealg::Geometry
sbndcode_RecoUtils
sbndcode_OpDetSim
sbndcode_BlipUtils
sbndobj_BlipDataTypes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation: copy the line above verbatim, then adjust the library name.

sbndcode_BlipRecoAlg
)

add_subdirectory(Utils)
add_subdirectory(Alg)

add_subdirectory(Utils)
cet_build_plugin(BlipAna art::Module SOURCE BlipAna_module.cc LIBRARIES ${MODULE_LIBRARIES} )
cet_build_plugin(BlipRecoProducer art::Module SOURCE BlipRecoProducer_module.cc LIBRARIES ${MODULE_LIBRARIES} )

Expand Down
2 changes: 1 addition & 1 deletion sbndcode/BlipRecoSBND/Utils/BlipUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
#include <vector>
#include <map>

#include "sbndcode/BlipRecoSBND/Utils/DataTypes.h"
#include "sbnobj/SBND/Blip/BlipDataTypes.h"
#include "TH1D.h"


Expand Down
1 change: 1 addition & 0 deletions sbndcode/BlipRecoSBND/Utils/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ cet_make_library(
ROOT::Gdml
sbndcode_CRTUtils
sbnobj::Common_CRT
sbndobj_BlipDataTypes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not need an sbnobj:: prefix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could name the library that way in the sbnobj CMAKE, but I chose an underscore. See https://github.com/SBNSoftware/sbnobj/pull/155/files#diff-9952908aa001973cd68cd85ca69225fa254a962de9cdf7cc3c395e0e2a16d762R1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is still good practice in my opinion to have the repository named, even if there is no current naming overlap. i.e. sbnobj::sbndobj_BlipDataTypes

#sbndcode_CosmicIdUtils
)

Expand Down
174 changes: 0 additions & 174 deletions sbndcode/BlipRecoSBND/Utils/DataTypes.h

This file was deleted.

36 changes: 0 additions & 36 deletions sbndcode/BlipRecoSBND/Utils/classes.h
Original file line number Diff line number Diff line change
@@ -1,36 +0,0 @@
//
// Build a dictionary.
//
// $Id: classes.h,v 1.8 2010/04/12 18:12:28 Exp $
// $Author: $
// $Date: 2010/04/12 18:12:28 $
//
// Original author Rob Kutschke, modified by wes
//

#include "canvas/Persistency/Common/Wrapper.h"

// data-products
// lardataobj
//#include "lardata/Utilities/AssociationUtil.h"
#include "canvas/Persistency/Common/Assns.h"
#include "lardataobj/RecoBase/PFParticle.h"
#include "lardataobj/RecoBase/Hit.h"
#include "nusimdata/SimulationBase/MCTruth.h"
#include "sbndcode/BlipRecoSBND/Utils/DataTypes.h"
#include "lardataobj/RecoBase/SpacePoint.h"

//
// Only include objects that we would like to be able to put into the event.
// Do not include the objects they contain internally.
//

template class art::Assns<recob::Hit,blip::Blip,void>;
template class art::Wrapper<art::Assns<recob::Hit,blip::Blip,void> >;
template class std::vector<blip::Blip>;
template class art::Wrapper<std::vector<blip::Blip> >;
template class std::map<int, TVector3>;
template class art::Assns<blip::Blip,recob::Hit,void>;
template class art::Wrapper<art::Assns<blip::Blip,recob::Hit,void> >;
template class art::Assns<blip::Blip,recob::SpacePoint,void>;
template class art::Wrapper<art::Assns<blip::Blip,recob::SpacePoint,void> >;
12 changes: 0 additions & 12 deletions sbndcode/BlipRecoSBND/Utils/classes_def.xml
Original file line number Diff line number Diff line change
@@ -1,14 +1,2 @@
<lcgdict>
<class name="art::Wrapper<std::vector<blip::Blip> >"/>
<class name="blip::Blip"/>
<class name="std::vector<blip::Blip>"/>
<class name="blip::HitClust"/>
<class name="blip::TrueBlip"/>
<class name="std::map<int,TVector3>"/>
<class name="art::Assns<blip::Blip,recob::Hit,void>"/>
<class name="art::Assns<recob::Hit, blip::Blip,void>"/>
<class name="art::Assns<blip::Blip,recob::SpacePoint,void>"/>
<class name="art::Wrapper<art::Assns<blip::Blip,recob::Hit,void> >"/>
<class name="art::Wrapper<art::Assns<recob::Hit,blip::Blip,void> >"/>
<class name="art::Wrapper<art::Assns<blip::Blip,recob::SpacePoint,void> >"/>
</lcgdict>
9 changes: 5 additions & 4 deletions sbndcode/CRT/CRTReco/CRTTrackProducer_module.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@

#include <memory>


namespace geo {
using Point2D_t = ROOT::Math::PositionVector2D<ROOT::Math::Cartesian2D<double>,
ROOT::Math::GlobalCoordinateSystemTag>;
Expand Down Expand Up @@ -245,8 +244,11 @@ std::vector<std::pair<sbnd::crt::CRTTrack, std::set<unsigned>>> sbnd::crt::CRTTr

BestFitLine(primarySpacePoint->Pos(), secondarySpacePoint->Pos(), tertiarySpacePoint->Pos(), primaryCluster->Tagger(),
secondaryCluster->Tagger(), tertiaryCluster->Tagger(), fitStart, fitMid, fitEnd, gof);

const CRTTrack track({fitStart, fitMid, fitEnd}, t0, et0, t1, et1, pe, tof, used_taggers);
const double _t0 = t0;
const double _et0 = et0;
const double _t1 = t1;
const double _et1 = et1;
const CRTTrack track({fitStart, fitMid, fitEnd}, _t0, _et0, _t1, _et1, pe, tof, used_taggers);
const std::set<unsigned> used_spacepoints = {i, ii, iii};

candidates.emplace_back(track, used_spacepoints);
Expand All @@ -265,7 +267,6 @@ std::vector<std::pair<sbnd::crt::CRTTrack, std::set<unsigned>>> sbnd::crt::CRTTr
const double pe = primarySpacePoint->PE() + secondarySpacePoint->PE();

const std::vector<CRTTagger> used_taggers = {primaryCluster->Tagger(), secondaryCluster->Tagger()};

const CRTTrack track(start, end, t0, et0, t1, et1, pe, tof, used_taggers);
const std::set<unsigned> used_spacepoints = {i, ii};

Expand Down
5 changes: 3 additions & 2 deletions sbndcode/JobConfigurations/standard/caf/cafmakerjob_sbnd.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -126,16 +126,17 @@ physics:
# change tools in sbn to have 2D TPC sim/sp input
physics.producers.pandoraShowerRazzle.SimChannelLabel: "simtpc2d:simpleSC"
physics.producers.pandoraTrackDazzle.SimChannelLabel: "simtpc2d:simpleSC"
physics.producers.cnnid.WireLabel: "simtpc2d:gauss"
#physics.producers.cnnid.WireLabel: "simtpc2d:gauss"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you commenting out this cnnid line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new ROI finding scheme we are keeping simtpc2d:dnnsp, but dropping simtpc2d:gauss.
Since this object is dropped I was getting errors trying to run CAFmaker without this comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there's two possibilities here:

  • Either, the default for this parameter is already "simtpc2d:dnnsp" in which case the line can be deleted not commented out.
  • Or, the default for this parameter is something else and so this line should be kept but point at "simtpc2d:dnnsp".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reiterating this comment - I see there is now a line below that points to "simtpc2d:dnnsp" so L129 can just be removed.

# uncomment below line for to use DNN ROI SP for CNNID scores
#physics.producers.cnnid.WireLabel: "simtpc2d:dnnsp"
physics.producers.cnnid.WireLabel: "simtpc2d:dnnsp"

physics.producers.vertexCharge.CaloAlg: @local::sbnd_calorimetryalgmc
physics.producers.vertexStub.CaloAlg: @local::sbnd_calorimetryalgmc

physics.producers.cafmaker: @local::standard_cafmaker
physics.producers.cafmaker.CosmicGenLabel: "corsika"
physics.producers.cafmaker.SimChannelLabel: "simtpc2d:simpleSC"
physics.producers.cafmaker.BlipTag: "blipreco"

# Blinding not needed for MC
physics.producers.cafmaker.CreateBlindedCAF: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ physics.producers.cafmaker.TPCPMTBarycenterMatchLabel: "tpcpmtbarycentermatching
physics.producers.cafmaker.CVNLabel: "cvnSCE"
physics.producers.cafmaker.CorrectedOpFlashLabel: "lightpropagationcorrectionSCE"
physics.producers.cnnid.WireLabel: "sptpc2d:dnnsp"
physics.producers.cafmaker.BlipTag: "blipreco"

physics.producers.cnnid.ClusterModuleLabel: "pandoraSCE"
physics.producers.cnnid.PFParticleModuleLabel: "pandoraSCE"
Expand All @@ -35,7 +36,7 @@ physics.producers.pandoraShowerCosmicDist.PandoraLabel: "pandoraSCE"
physics.producers.pandoraShowerCosmicDist.ShowerLabel: "pandoraSCEShowerSBN"
physics.producers.pandoraShowerRazzle.PFPLabel: "pandoraSCE"
physics.producers.pandoraShowerRazzle.ShowerLabel: "pandoraSCEShowerSBN"

physics.producers.pandoraShowerRazzle.SimChannelLabel: "sptpc2d:dnnsp"
physics.producers.pandoraRazzled: @local::razzled_sbnd_sce

physics.producers.pandoraTrackClosestApproach.TrackLabel: "pandoraSCETrack"
Expand All @@ -53,6 +54,8 @@ physics.producers.pandoraTrackDazzle.PFPLabel: "pandoraSCE"
physics.producers.pandoraTrackDazzle.TrackLabel: "pandoraSCETrack"
physics.producers.pandoraTrackDazzle.CaloLabel: "pandoraSCECaloData"
physics.producers.pandoraTrackDazzle.Chi2Label: "pandoraSCEPidData"
physics.producers.pandoraTrackDazzle.SimChannelLabel: "sptpc2d:dnnsp"


physics.producers.fmatchSCE: @local::transfer_flashmatch_sce_sbnd
physics.producers.fmatchopSCE: @local::transfer_flashmatch_sce_sbnd
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ physics.producers.cafmaker.CRTTrackMatchLabel: "pandoraSCETrackCRTTrack"
physics.producers.cafmaker.OpT0Label: "opt0finderSCE"
physics.producers.cafmaker.TPCPMTBarycenterMatchLabel: "tpcpmtbarycentermatchingSCE"
physics.producers.cafmaker.CVNLabel: "cvnSCE"
physics.producers.cafmaker.BlipTag: "blipreco"

physics.producers.cnnid.ClusterModuleLabel: "pandoraSCE"
physics.producers.cnnid.PFParticleModuleLabel: "pandoraSCE"
Expand Down
Loading