[FIX] 네이버 로그인에 대한 ExceptionAdvice 적용 #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlp-sy
requested review from
FromKyoung and
msk226
and removed request for
msk226
msk226
approved these changes
Jan 5, 2025
Member
msk226
left a comment
msk226
left a comment
There was a problem hiding this comment.
네이버 로그인 하시느라 고생 정말 많으십니다...!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
🔎 작업 내용
네이버 로그인 시 내부적으로 네이버 API를 호출하고 JsonProcessingException으로 throw하는 로직이 있었는데, ExceptionAdvice에 JsonProcessingException에 대한 예외 처리를 별도로 구현하지 않아서 Exception으로 throw 하도록 수정했습니다.
JsonProcessingException이 발생하더라도 저희가 지정한 Json 포맷으로 응답을 전송할 수 있도록 만든 것입니당 😆
📷 스크린샷 (선택)
💬리뷰 요구사항 (선택)