Feat/scmi 124866 [Domain models initiative] value attribute VO lint rule #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleixadevinta
requested review from
sui-bot,
kikoruiz,
andresz1 and
carlosvillu
as code owners
aleixadevinta
changed the title
oriolpuig
reviewed
Jul 24, 2024
| const filePath = context.getFilename() | ||
| const relativePath = path.relative(context.getCwd(), filePath) | ||
|
|
||
| // Check if the file is inside requierd folders (useCases, services, repositories, ...) |
There was a problem hiding this comment.
👀 update comment or remove it
kikoruiz
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request we ensure that a value object with one attribute class has a private
valueattribute and his own public getter.Related Issue
SCMI-124922