Skip to content

Conversation

@kyleaoman
Copy link
Member

@kyleaoman kyleaoman commented Oct 9, 2025

Closes #55
Depends on SWIFTSIM/swiftsimio#258

With better management of file opening/closing on the swiftsimio side, and using requests instead of wget, the swiftgalaxy test suite should be able to run on windows and macos platforms.

  • Once the swiftsimio patch merges (now merged) and releases (not yet), reset the dependency to the pypi version. Then this can be merged if tests pass.

@kyleaoman kyleaoman self-assigned this Oct 9, 2025
@kyleaoman kyleaoman added the enhancement New feature or request label Oct 9, 2025
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (17b2eb1) to head (ee870cc).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2314      2314           
  Branches       265       265           
=========================================
  Hits          2314      2314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kyleaoman kyleaoman merged commit e02fd48 into main Oct 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyOpenSci review - Errors during testing on Windows machine

2 participants